Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

V4L/DVB (6578): dvb-usb: make some debug vars static

This patch makes some needlessly global debug variables static.

opera1.h became so small that I removed it.

Signed-off-by: Adrian Bunk <bunk@kernel.org>
Reviewed-by: Michael Krufky <mkrufky@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>

authored by

Adrian Bunk and committed by
Mauro Carvalho Chehab
53133afb f760d618

+14 -27
+4 -1
drivers/media/dvb/dvb-usb/cxusb.c
··· 32 32 #include "zl10353.h" 33 33 34 34 /* debug */ 35 - int dvb_usb_cxusb_debug; 35 + static int dvb_usb_cxusb_debug; 36 36 module_param_named(debug, dvb_usb_cxusb_debug, int, 0644); 37 37 MODULE_PARM_DESC(debug, "set debugging level (1=rc (or-able))." DVB_USB_DEBUG_STATUS); 38 + #define deb_info(args...) dprintk(dvb_usb_cxusb_debug,0x01,args) 39 + #define deb_i2c(args...) if (d->udev->descriptor.idVendor == USB_VID_MEDION) \ 40 + dprintk(dvb_usb_cxusb_debug,0x01,args) 38 41 39 42 static int cxusb_ctrl_msg(struct dvb_usb_device *d, 40 43 u8 cmd, u8 *wbuf, int wlen, u8 *rbuf, int rlen)
-5
drivers/media/dvb/dvb-usb/cxusb.h
··· 4 4 #define DVB_USB_LOG_PREFIX "cxusb" 5 5 #include "dvb-usb.h" 6 6 7 - extern int dvb_usb_cxusb_debug; 8 - #define deb_info(args...) dprintk(dvb_usb_cxusb_debug,0x01,args) 9 - #define deb_i2c(args...) if (d->udev->descriptor.idVendor == USB_VID_MEDION) \ 10 - dprintk(dvb_usb_cxusb_debug,0x01,args) 11 - 12 7 /* usb commands - some of it are guesses, don't have a reference yet */ 13 8 #define CMD_I2C_WRITE 0x08 14 9 #define CMD_I2C_READ 0x09
+2 -1
drivers/media/dvb/dvb-usb/digitv.c
··· 17 17 #include "nxt6000.h" 18 18 19 19 /* debug */ 20 - int dvb_usb_digitv_debug; 20 + static int dvb_usb_digitv_debug; 21 21 module_param_named(debug,dvb_usb_digitv_debug, int, 0644); 22 22 MODULE_PARM_DESC(debug, "set debugging level (1=rc (or-able))." DVB_USB_DEBUG_STATUS); 23 + #define deb_rc(args...) dprintk(dvb_usb_digitv_debug,0x01,args) 23 24 24 25 static int digitv_ctrl_msg(struct dvb_usb_device *d, 25 26 u8 cmd, u8 vv, u8 *wbuf, int wlen, u8 *rbuf, int rlen)
-3
drivers/media/dvb/dvb-usb/digitv.h
··· 8 8 int is_nxt6000; 9 9 }; 10 10 11 - extern int dvb_usb_digitv_debug; 12 - #define deb_rc(args...) dprintk(dvb_usb_digitv_debug,0x01,args) 13 - 14 11 /* protocol (from usblogging and the SDK: 15 12 * 16 13 * Always 7 bytes bulk message(s) for controlling
+4 -2
drivers/media/dvb/dvb-usb/opera1.c
··· 10 10 * see Documentation/dvb/README.dvb-usb for more information 11 11 */ 12 12 13 - #include "opera1.h" 13 + #define DVB_USB_LOG_PREFIX "opera" 14 + 15 + #include "dvb-usb.h" 14 16 #include "stv0299.h" 15 17 16 18 #define OPERA_READ_MSG 0 ··· 40 38 u32 event; 41 39 }; 42 40 43 - int dvb_usb_opera1_debug; 41 + static int dvb_usb_opera1_debug; 44 42 module_param_named(debug, dvb_usb_opera1_debug, int, 0644); 45 43 MODULE_PARM_DESC(debug, 46 44 "set debugging level (1=info,xfer=2,pll=4,ts=8,err=16,rc=32,fw=64 (or-able))."
-9
drivers/media/dvb/dvb-usb/opera1.h
··· 1 - #ifndef _OPERA1_H_ 2 - #define _OPERA1_H_ 3 - 4 - #define DVB_USB_LOG_PREFIX "opera" 5 - #include "dvb-usb.h" 6 - 7 - extern int dvb_usb_opera1_debug; 8 - #define deb_xfer(args...) dprintk(dvb_usb_opera1_debug,0x02,args) 9 - #endif
+4 -1
drivers/media/dvb/dvb-usb/vp7045.c
··· 15 15 #include "vp7045.h" 16 16 17 17 /* debug */ 18 - int dvb_usb_vp7045_debug; 18 + static int dvb_usb_vp7045_debug; 19 19 module_param_named(debug,dvb_usb_vp7045_debug, int, 0644); 20 20 MODULE_PARM_DESC(debug, "set debugging level (1=info,xfer=2,rc=4 (or-able))." DVB_USB_DEBUG_STATUS); 21 + #define deb_info(args...) dprintk(dvb_usb_vp7045_debug,0x01,args) 22 + #define deb_xfer(args...) dprintk(dvb_usb_vp7045_debug,0x02,args) 23 + #define deb_rc(args...) dprintk(dvb_usb_vp7045_debug,0x04,args) 21 24 22 25 int vp7045_usb_op(struct dvb_usb_device *d, u8 cmd, u8 *out, int outlen, u8 *in, int inlen, int msec) 23 26 {
-5
drivers/media/dvb/dvb-usb/vp7045.h
··· 17 17 #define DVB_USB_LOG_PREFIX "vp7045" 18 18 #include "dvb-usb.h" 19 19 20 - extern int dvb_usb_vp7045_debug; 21 - #define deb_info(args...) dprintk(dvb_usb_vp7045_debug,0x01,args) 22 - #define deb_xfer(args...) dprintk(dvb_usb_vp7045_debug,0x02,args) 23 - #define deb_rc(args...) dprintk(dvb_usb_vp7045_debug,0x04,args) 24 - 25 20 /* vp7045 commands */ 26 21 27 22 /* Twinhan Vendor requests */