Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

locking/rt: Add sparse annotation PREEMPT_RT's sleeping locks.

The sleeping locks on PREEMPT_RT (rt_spin_lock() and friends) lack
sparse annotation. Therefore a missing spin_unlock() won't be spotted by
sparse in a PREEMPT_RT build while it is noticed on a !PREEMPT_RT build.

Add the __acquires/__releases macros to the lock/ unlock functions. The
trylock functions already use the __cond_lock() wrapper.

Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/all/20240812104200.2239232-2-bigeasy@linutronix.de

authored by

Sebastian Andrzej Siewior and committed by
Thomas Gleixner
52e0874f 2628cbd0

+9 -9
+5 -5
include/linux/rwlock_rt.h
··· 24 24 __rt_rwlock_init(rwl, #rwl, &__key); \ 25 25 } while (0) 26 26 27 - extern void rt_read_lock(rwlock_t *rwlock); 27 + extern void rt_read_lock(rwlock_t *rwlock) __acquires(rwlock); 28 28 extern int rt_read_trylock(rwlock_t *rwlock); 29 - extern void rt_read_unlock(rwlock_t *rwlock); 30 - extern void rt_write_lock(rwlock_t *rwlock); 31 - extern void rt_write_lock_nested(rwlock_t *rwlock, int subclass); 29 + extern void rt_read_unlock(rwlock_t *rwlock) __releases(rwlock); 30 + extern void rt_write_lock(rwlock_t *rwlock) __acquires(rwlock); 31 + extern void rt_write_lock_nested(rwlock_t *rwlock, int subclass) __acquires(rwlock); 32 32 extern int rt_write_trylock(rwlock_t *rwlock); 33 - extern void rt_write_unlock(rwlock_t *rwlock); 33 + extern void rt_write_unlock(rwlock_t *rwlock) __releases(rwlock); 34 34 35 35 static __always_inline void read_lock(rwlock_t *rwlock) 36 36 {
+4 -4
include/linux/spinlock_rt.h
··· 32 32 __rt_spin_lock_init(slock, #slock, &__key, true); \ 33 33 } while (0) 34 34 35 - extern void rt_spin_lock(spinlock_t *lock); 36 - extern void rt_spin_lock_nested(spinlock_t *lock, int subclass); 37 - extern void rt_spin_lock_nest_lock(spinlock_t *lock, struct lockdep_map *nest_lock); 38 - extern void rt_spin_unlock(spinlock_t *lock); 35 + extern void rt_spin_lock(spinlock_t *lock) __acquires(lock); 36 + extern void rt_spin_lock_nested(spinlock_t *lock, int subclass) __acquires(lock); 37 + extern void rt_spin_lock_nest_lock(spinlock_t *lock, struct lockdep_map *nest_lock) __acquires(lock); 38 + extern void rt_spin_unlock(spinlock_t *lock) __releases(lock); 39 39 extern void rt_spin_lock_unlock(spinlock_t *lock); 40 40 extern int rt_spin_trylock_bh(spinlock_t *lock); 41 41 extern int rt_spin_trylock(spinlock_t *lock);