Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

Input: lm8323 - add missing device_remove_file for dev_attr_time

Add missing device_remove_file() for dev_attr_time in lm8323_remove().
Also calling device_remove_file() in lm8323_probe() error path to
remove sysfs attribute file.

Signed-off-by: Axel Lin <axel.lin@gmail.com>
Signed-off-by: Dmitry Torokhov <dtor@mail.ru>

authored by

Axel Lin and committed by
Dmitry Torokhov
52db9819 3f27757a

+7 -2
+7 -2
drivers/input/keyboard/lm8323.c
··· 754 754 device_remove_file(&client->dev, &dev_attr_disable_kp); 755 755 fail2: 756 756 while (--pwm >= 0) 757 - if (lm->pwm[pwm].enabled) 757 + if (lm->pwm[pwm].enabled) { 758 + device_remove_file(lm->pwm[pwm].cdev.dev, 759 + &dev_attr_time); 758 760 led_classdev_unregister(&lm->pwm[pwm].cdev); 761 + } 759 762 fail1: 760 763 input_free_device(idev); 761 764 kfree(lm); ··· 778 775 device_remove_file(&lm->client->dev, &dev_attr_disable_kp); 779 776 780 777 for (i = 0; i < 3; i++) 781 - if (lm->pwm[i].enabled) 778 + if (lm->pwm[i].enabled) { 779 + device_remove_file(lm->pwm[i].cdev.dev, &dev_attr_time); 782 780 led_classdev_unregister(&lm->pwm[i].cdev); 781 + } 783 782 784 783 kfree(lm); 785 784