Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

Staging: vc04_services: Cleanup in ctrl_set_bitrate()

Remove unnecessary variable from the function and make a corresponding
change w.r.t the variable. In addition to that align the parameters in
the parentheses to maintain Linux kernel coding style

Issue suggested by Coccinelle.

Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

authored by

Madhumitha Prabakaran and committed by
Greg Kroah-Hartman
52c4dfce 06e8c289

+3 -6
+3 -6
drivers/staging/vc04_services/bcm2835-camera/controls.c
··· 607 607 struct v4l2_ctrl *ctrl, 608 608 const struct bm2835_mmal_v4l2_ctrl *mmal_ctrl) 609 609 { 610 - int ret; 611 610 struct vchiq_mmal_port *encoder_out; 612 611 613 612 dev->capture.encode_bitrate = ctrl->val; 614 613 615 614 encoder_out = &dev->component[MMAL_COMPONENT_VIDEO_ENCODE]->output[0]; 616 615 617 - ret = vchiq_mmal_port_parameter_set(dev->instance, encoder_out, 618 - mmal_ctrl->mmal_id, 619 - &ctrl->val, sizeof(ctrl->val)); 620 - ret = 0; 621 - return ret; 616 + return vchiq_mmal_port_parameter_set(dev->instance, encoder_out, 617 + mmal_ctrl->mmal_id, &ctrl->val, 618 + sizeof(ctrl->val)); 622 619 } 623 620 624 621 static int ctrl_set_bitrate_mode(struct bm2835_mmal_dev *dev,