Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

hwmon: (gpio-fan) Allow usage of gpio operations that may sleep

Certain I2C based GPIO expanders could be used in sleepable context,
this results in:
[ 115.890569] ------------[ cut here ]------------
[ 115.895422] WARNING: CPU: 0 PID: 1115 at drivers/gpio/gpiolib.c:1370 gpiod_set_raw_value+0x40/0x4c()
[ 115.905024] Modules linked in:
[ 115.908229] CPU: 0 PID: 1115 Comm: sh Tainted: G W 3.18.0-rc7-next-20141203-dirty #1
[ 115.917461] Hardware name: Generic DRA74X (Flattened Device Tree)
[ 115.923876] [<c0015368>] (unwind_backtrace) from [<c00119f4>] (show_stack+0x10/0x14)
[ 115.932013] [<c00119f4>] (show_stack) from [<c05b78e8>] (dump_stack+0x78/0x94)
[ 115.939594] [<c05b78e8>] (dump_stack) from [<c003de28>] (warn_slowpath_common+0x7c/0xb4)
[ 115.948094] [<c003de28>] (warn_slowpath_common) from [<c003de7c>] (warn_slowpath_null+0x1c/0x24)
[ 115.957315] [<c003de7c>] (warn_slowpath_null) from [<c03461e8>] (gpiod_set_raw_value+0x40/0x4c)
[ 115.966457] [<c03461e8>] (gpiod_set_raw_value) from [<c04866f4>] (set_fan_speed+0x4c/0x64)
[ 115.975145] [<c04866f4>] (set_fan_speed) from [<c04868a8>] (set_rpm+0x98/0xac)
[ 115.982742] [<c04868a8>] (set_rpm) from [<c039fb4c>] (dev_attr_store+0x18/0x24)
[ 115.990426] [<c039fb4c>] (dev_attr_store) from [<c01b0a28>] (sysfs_kf_write+0x4c/0x50)
[ 115.998742] [<c01b0a28>] (sysfs_kf_write) from [<c01afe1c>] (kernfs_fop_write+0xbc/0x19c)
[ 116.007333] [<c01afe1c>] (kernfs_fop_write) from [<c0148cc4>] (vfs_write+0xb0/0x1a0)
[ 116.015461] [<c0148cc4>] (vfs_write) from [<c0148fbc>] (SyS_write+0x44/0x84)
[ 116.022881] [<c0148fbc>] (SyS_write) from [<c000e5c0>] (ret_fast_syscall+0x0/0x48)
[ 116.030833] ---[ end trace 3a0b636123acab82 ]---

So, switch over to sleepable GPIO operations as there is no mandatory
need for non-sleepable gpio operations in the fan driver.

This allows the fan driver to be used with i2c based gpio expanders such
as palmas_gpio.

Signed-off-by: Nishanth Menon <nm@ti.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>

authored by

Nishanth Menon and committed by
Guenter Roeck
52a95c11 90652efe

+5 -4
+5 -4
drivers/hwmon/gpio-fan.c
··· 79 79 { 80 80 struct gpio_fan_data *fan_data = dev_get_drvdata(dev); 81 81 struct gpio_fan_alarm *alarm = fan_data->alarm; 82 - int value = gpio_get_value(alarm->gpio); 82 + int value = gpio_get_value_cansleep(alarm->gpio); 83 83 84 84 if (alarm->active_low) 85 85 value = !value; ··· 131 131 int i; 132 132 133 133 for (i = 0; i < fan_data->num_ctrl; i++) 134 - gpio_set_value(fan_data->ctrl[i], (ctrl_val >> i) & 1); 134 + gpio_set_value_cansleep(fan_data->ctrl[i], (ctrl_val >> i) & 1); 135 135 } 136 136 137 137 static int __get_fan_ctrl(struct gpio_fan_data *fan_data) ··· 142 142 for (i = 0; i < fan_data->num_ctrl; i++) { 143 143 int value; 144 144 145 - value = gpio_get_value(fan_data->ctrl[i]); 145 + value = gpio_get_value_cansleep(fan_data->ctrl[i]); 146 146 ctrl_val |= (value << i); 147 147 } 148 148 return ctrl_val; ··· 369 369 if (err) 370 370 return err; 371 371 372 - err = gpio_direction_output(ctrl[i], gpio_get_value(ctrl[i])); 372 + err = gpio_direction_output(ctrl[i], 373 + gpio_get_value_cansleep(ctrl[i])); 373 374 if (err) 374 375 return err; 375 376 }