Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

perf dlfilter: Be defensive against potential NULL dereference

In the unlikely case of having a symbol without a mapping, avoid a
NULL dereference that clang-tidy warns about.

Signed-off-by: Ian Rogers <irogers@google.com>
Acked-by: Namhyung Kim <namhyung@kernel.org>
Cc: Ravi Bangoria <ravi.bangoria@amd.com>
Cc: Nick Desaulniers <ndesaulniers@google.com>
Cc: Yang Jihong <yangjihong1@huawei.com>
Cc: Huacai Chen <chenhuacai@kernel.org>
Cc: Nathan Chancellor <nathan@kernel.org>
Cc: Kan Liang <kan.liang@linux.intel.com>
Cc: llvm@lists.linux.dev
Cc: Ming Wang <wangming01@loongson.cn>
Cc: Tom Rix <trix@redhat.com>
Cc: bpf@vger.kernel.org
Link: https://lore.kernel.org/r/20231009183920.200859-11-irogers@google.com
Signed-off-by: Namhyung Kim <namhyung@kernel.org>

authored by

Ian Rogers and committed by
Namhyung Kim
52a5ad12 85f73c37

+3 -1
+3 -1
tools/perf/util/dlfilter.c
··· 52 52 d_al->sym_end = sym->end; 53 53 if (al->addr < sym->end) 54 54 d_al->symoff = al->addr - sym->start; 55 - else 55 + else if (al->map) 56 56 d_al->symoff = al->addr - map__start(al->map) - sym->start; 57 + else 58 + d_al->symoff = 0; 57 59 d_al->sym_binding = sym->binding; 58 60 } else { 59 61 d_al->sym = NULL;