Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

[NET]: improve readability of dev_set_promiscuity() in net/core/dev.c

A trivial patch to improve the readability of dev_set_promiscuity()
in net/core/dev.c. New code does exactly the same thing as original
code.

Signed-off-by: David Chau <ddcc@mit.edu>
Signed-off-by: Domen Puncer <domen@coderock.org>
Signed-off-by: David S. Miller <davem@davemloft.net>

authored by

David Chau and committed by
David S. Miller
52609c0b bc971dee

+3 -2
+3 -2
net/core/dev.c
··· 2089 2089 { 2090 2090 unsigned short old_flags = dev->flags; 2091 2091 2092 - dev->flags |= IFF_PROMISC; 2093 2092 if ((dev->promiscuity += inc) == 0) 2094 2093 dev->flags &= ~IFF_PROMISC; 2095 - if (dev->flags ^ old_flags) { 2094 + else 2095 + dev->flags |= IFF_PROMISC; 2096 + if (dev->flags != old_flags) { 2096 2097 dev_mc_upload(dev); 2097 2098 printk(KERN_INFO "device %s %s promiscuous mode\n", 2098 2099 dev->name, (dev->flags & IFF_PROMISC) ? "entered" :