Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

iio: adc: npcm: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new() which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230919174931.1417681-18-u.kleine-koenig@pengutronix.de
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

authored by

Uwe Kleine-König and committed by
Jonathan Cameron
5253a5cc a72e156f

+2 -4
+2 -4
drivers/iio/adc/npcm_adc.c
··· 320 320 return ret; 321 321 } 322 322 323 - static int npcm_adc_remove(struct platform_device *pdev) 323 + static void npcm_adc_remove(struct platform_device *pdev) 324 324 { 325 325 struct iio_dev *indio_dev = platform_get_drvdata(pdev); 326 326 struct npcm_adc *info = iio_priv(indio_dev); ··· 333 333 if (!IS_ERR(info->vref)) 334 334 regulator_disable(info->vref); 335 335 clk_disable_unprepare(info->adc_clk); 336 - 337 - return 0; 338 336 } 339 337 340 338 static struct platform_driver npcm_adc_driver = { 341 339 .probe = npcm_adc_probe, 342 - .remove = npcm_adc_remove, 340 + .remove_new = npcm_adc_remove, 343 341 .driver = { 344 342 .name = "npcm_adc", 345 343 .of_match_table = npcm_adc_match,