Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

fbdev: uvesafb: use sysfs_emit() to instead of scnprintf()

Follow the advice of the Documentation/filesystems/sysfs.rst and show()
should only use sysfs_emit() or sysfs_emit_at() when formatting the
value to be returned to user space.

Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
Signed-off-by: Helge Deller <deller@gmx.de>

authored by

ye xingchen and committed by
Helge Deller
522d5226 f2ff0c43

+5 -5
+5 -5
drivers/video/fbdev/uvesafb.c
··· 1580 1580 struct uvesafb_par *par = info->par; 1581 1581 1582 1582 if (par->vbe_ib.oem_vendor_name_ptr) 1583 - return scnprintf(buf, PAGE_SIZE, "%s\n", (char *) 1583 + return sysfs_emit(buf, "%s\n", (char *) 1584 1584 (&par->vbe_ib) + par->vbe_ib.oem_vendor_name_ptr); 1585 1585 else 1586 1586 return 0; ··· 1595 1595 struct uvesafb_par *par = info->par; 1596 1596 1597 1597 if (par->vbe_ib.oem_product_name_ptr) 1598 - return scnprintf(buf, PAGE_SIZE, "%s\n", (char *) 1598 + return sysfs_emit(buf, "%s\n", (char *) 1599 1599 (&par->vbe_ib) + par->vbe_ib.oem_product_name_ptr); 1600 1600 else 1601 1601 return 0; ··· 1610 1610 struct uvesafb_par *par = info->par; 1611 1611 1612 1612 if (par->vbe_ib.oem_product_rev_ptr) 1613 - return scnprintf(buf, PAGE_SIZE, "%s\n", (char *) 1613 + return sysfs_emit(buf, "%s\n", (char *) 1614 1614 (&par->vbe_ib) + par->vbe_ib.oem_product_rev_ptr); 1615 1615 else 1616 1616 return 0; ··· 1625 1625 struct uvesafb_par *par = info->par; 1626 1626 1627 1627 if (par->vbe_ib.oem_string_ptr) 1628 - return scnprintf(buf, PAGE_SIZE, "%s\n", 1628 + return sysfs_emit(buf, "%s\n", 1629 1629 (char *)(&par->vbe_ib) + par->vbe_ib.oem_string_ptr); 1630 1630 else 1631 1631 return 0; ··· 1639 1639 struct fb_info *info = dev_get_drvdata(dev); 1640 1640 struct uvesafb_par *par = info->par; 1641 1641 1642 - return scnprintf(buf, PAGE_SIZE, "%d\n", par->nocrtc); 1642 + return sysfs_emit(buf, "%d\n", par->nocrtc); 1643 1643 } 1644 1644 1645 1645 static ssize_t uvesafb_store_nocrtc(struct device *dev,