tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
fork atom

fsnotify: use def_bool in kconfig instead of letting the user choose

fsnotify doens't give the user anything. If someone chooses inotify or
dnotify it should build fsnotify, if they don't select one it shouldn't be
built. This patch changes fsnotify to be a def_bool=n and makes everything
else select it. Also fixes the issue people complained about on lwn where
gdm hung because they didn't have inotify and they didn't get the inotify
build option.....

Signed-off-by: Eric Paris <eparis@redhat.com>

Eric Paris 520dc2a5 7e790dd5

+3 -13
+1 -11
fs/notify/Kconfig
··· 1 1 config FSNOTIFY 2 - bool "Filesystem notification backend" 3 - default y 4 - ---help--- 5 - fsnotify is a backend for filesystem notification. fsnotify does 6 - not provide any userspace interface but does provide the basis 7 - needed for other notification schemes such as dnotify, inotify, 8 - and fanotify. 9 - 10 - Say Y here to enable fsnotify suport. 11 - 12 - If unsure, say Y. 2 + def_bool n 13 3 14 4 source "fs/notify/dnotify/Kconfig" 15 5 source "fs/notify/inotify/Kconfig"
+1 -1
fs/notify/dnotify/Kconfig
··· 1 1 config DNOTIFY 2 2 bool "Dnotify support" 3 - depends on FSNOTIFY 3 + select FSNOTIFY 4 4 default y 5 5 help 6 6 Dnotify is a directory-based per-fd file change notification system
+1 -1
fs/notify/inotify/Kconfig
··· 15 15 16 16 config INOTIFY_USER 17 17 bool "Inotify support for userspace" 18 - depends on FSNOTIFY 18 + select FSNOTIFY 19 19 default y 20 20 ---help--- 21 21 Say Y here to enable inotify support for userspace, including the