Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

random: fix warning message on ia64 and parisc

Fix the warning message on the parisc and IA64 architectures to show the
correct function name of the caller by using %pS instead of %pF. The
message is printed with the value of _RET_IP_ which calls
__builtin_return_address(0) and as such returns the IP address caller
instead of pointer to a function descriptor of the caller.

The effect of this patch is visible on the parisc and ia64 architectures
only since those are the ones which use function descriptors while on
all others %pS and %pF will behave the same.

Cc: Theodore Ts'o <tytso@mit.edu>
Cc: Jason A. Donenfeld <Jason@zx2c4.com>
Signed-off-by: Helge Deller <deller@gmx.de>
Fixes: eecabf567422 ("random: suppress spammy warnings about unseeded randomness")
Fixes: d06bfd1989fe ("random: warn when kernel uses unseeded randomness")
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

authored by

Helge Deller and committed by
Linus Torvalds
51d96dc2 623ce345

+1 -1
+1 -1
drivers/char/random.c
··· 1492 1492 #ifndef CONFIG_WARN_ALL_UNSEEDED_RANDOM 1493 1493 print_once = true; 1494 1494 #endif 1495 - pr_notice("random: %s called from %pF with crng_init=%d\n", 1495 + pr_notice("random: %s called from %pS with crng_init=%d\n", 1496 1496 func_name, caller, crng_init); 1497 1497 } 1498 1498