tjh.dev
Linux kernel mirror (for testing)
git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel
os
linux
Staging: asus_oled: fix up my fixup for some sysfs attribute permissions
They should be writable by root, not readable.
Doh, stupid me with the wrong flags.
Reported-by: Jonathan Cameron <jic23@cam.ac.uk>
Cc: Jakub Schmidtke <sjakub@gmail.com>
Cc: stable <stable@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
+4
-4
+4
-4
drivers/staging/asus_oled/asus_oled.c
+4
-4
drivers/staging/asus_oled/asus_oled.c
···
620
620
621
621
#define ASUS_OLED_DEVICE_ATTR(_file) dev_attr_asus_oled_##_file
622
622
623
-
static DEVICE_ATTR(asus_oled_enabled, S_IRUSR | S_IRUGO,
623
+
static DEVICE_ATTR(asus_oled_enabled, S_IWUSR | S_IRUGO,
624
624
get_enabled, set_enabled);
625
-
static DEVICE_ATTR(asus_oled_picture, S_IRUSR , NULL, set_picture);
625
+
static DEVICE_ATTR(asus_oled_picture, S_IWUSR , NULL, set_picture);
626
626
627
-
static DEVICE_ATTR(enabled, S_IRUSR | S_IRUGO,
627
+
static DEVICE_ATTR(enabled, S_IWUSR | S_IRUGO,
628
628
class_get_enabled, class_set_enabled);
629
-
static DEVICE_ATTR(picture, S_IRUSR, NULL, class_set_picture);
629
+
static DEVICE_ATTR(picture, S_IWUSR, NULL, class_set_picture);
630
630
631
631
static int asus_oled_probe(struct usb_interface *interface,
632
632
const struct usb_device_id *id)