sched/isolation: Prevent boot crash when the boot CPU is nohz_full

Documentation/timers/no_hz.rst states that the "nohz_full=" mask must not
include the boot CPU, which is no longer true after:

08ae95f4fd3b ("nohz_full: Allow the boot CPU to be nohz_full").

However after:

aae17ebb53cd ("workqueue: Avoid using isolated cpus' timers on queue_delayed_work")

the kernel will crash at boot time in this case; housekeeping_any_cpu()
returns an invalid CPU number until smp_init() brings the first
housekeeping CPU up.

Change housekeeping_any_cpu() to check the result of cpumask_any_and() and
return smp_processor_id() in this case.

This is just the simple and backportable workaround which fixes the
symptom, but smp_processor_id() at boot time should be safe at least for
type == HK_TYPE_TIMER, this more or less matches the tick_do_timer_boot_cpu
logic.

There is no worry about cpu_down(); tick_nohz_cpu_down() will not allow to
offline tick_do_timer_cpu (the 1st online housekeeping CPU).

Fixes: aae17ebb53cd ("workqueue: Avoid using isolated cpus' timers on queue_delayed_work")
Reported-by: Chris von Recklinghausen <crecklin@redhat.com>
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Reviewed-by: Phil Auld <pauld@redhat.com>
Acked-by: Frederic Weisbecker <frederic@kernel.org>
Link: https://lore.kernel.org/r/20240411143905.GA19288@redhat.com
Closes: https://lore.kernel.org/all/20240402105847.GA24832@redhat.com/

authored by Oleg Nesterov and committed by Ingo Molnar 5097cbcb 1560d1f6

Changed files
+12 -6
Documentation
timers
kernel
sched
+2 -5
Documentation/timers/no_hz.rst
··· 129 129 online to handle timekeeping tasks in order to ensure that system 130 130 calls like gettimeofday() returns accurate values on adaptive-tick CPUs. 131 131 (This is not an issue for CONFIG_NO_HZ_IDLE=y because there are no running 132 - user processes to observe slight drifts in clock rate.) Therefore, the 133 - boot CPU is prohibited from entering adaptive-ticks mode. Specifying a 134 - "nohz_full=" mask that includes the boot CPU will result in a boot-time 135 - error message, and the boot CPU will be removed from the mask. Note that 136 - this means that your system must have at least two CPUs in order for 132 + user processes to observe slight drifts in clock rate.) Note that this 133 + means that your system must have at least two CPUs in order for 137 134 CONFIG_NO_HZ_FULL=y to do anything for you. 138 135 139 136 Finally, adaptive-ticks CPUs must have their RCU callbacks offloaded.
+10 -1
kernel/sched/isolation.c
··· 46 46 if (cpu < nr_cpu_ids) 47 47 return cpu; 48 48 49 - return cpumask_any_and(housekeeping.cpumasks[type], cpu_online_mask); 49 + cpu = cpumask_any_and(housekeeping.cpumasks[type], cpu_online_mask); 50 + if (likely(cpu < nr_cpu_ids)) 51 + return cpu; 52 + /* 53 + * Unless we have another problem this can only happen 54 + * at boot time before start_secondary() brings the 1st 55 + * housekeeping CPU up. 56 + */ 57 + WARN_ON_ONCE(system_state == SYSTEM_RUNNING || 58 + type != HK_TYPE_TIMER); 50 59 } 51 60 } 52 61 return smp_processor_id();