Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

KEYS: remove a bogus NULL check

We already checked if "desc" was NULL at the beginning of the function
and we've dereferenced it so this causes a static checker warning.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David Howells <dhowells@redhat.com>
Signed-off-by: James Morris <james.l.morris@oracle.com>

authored by

Dan Carpenter and committed by
James Morris
5057975a d0bffab0

+4 -6
+4 -6
security/keys/key.c
··· 276 276 if (!key) 277 277 goto no_memory_2; 278 278 279 - if (desc) { 280 - key->index_key.desc_len = desclen; 281 - key->index_key.description = kmemdup(desc, desclen + 1, GFP_KERNEL); 282 - if (!key->description) 283 - goto no_memory_3; 284 - } 279 + key->index_key.desc_len = desclen; 280 + key->index_key.description = kmemdup(desc, desclen + 1, GFP_KERNEL); 281 + if (!key->description) 282 + goto no_memory_3; 285 283 286 284 atomic_set(&key->usage, 1); 287 285 init_rwsem(&key->sem);