tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
fork atom

drm/format-helper: Use KUNIT_EXPECT_MEMEQ macro

Commit b8a926bea8b1 ("kunit: Introduce KUNIT_EXPECT_MEMEQ and
KUNIT_EXPECT_MEMNEQ macros") introduced a new macro to compare blocks of
memory and, if the test fails, print the result in a human-friendly
format. Therefore, use KUNIT_EXPECT_MEMEQ to compare memory blocks in
replacement of the KUNIT_EXPECT_EQ macro.

Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: David Gow <davidgow@google.com>
Signed-off-by: Maíra Canal <mairacanal@riseup.net>
Link: https://patchwork.freedesktop.org/patch/msgid/20230130125554.363481-1-mairacanal@riseup.net

Maíra Canal 4fae160f c913cd54

+5 -5
+5 -5
drivers/gpu/drm/tests/drm_format_helper_test.c
··· 597 597 598 598 drm_fb_xrgb8888_to_xrgb1555(&dst, &result->dst_pitch, &src, &fb, &params->clip); 599 599 buf = le16buf_to_cpu(test, (__force const __le16 *)buf, dst_size / sizeof(__le16)); 600 - KUNIT_EXPECT_EQ(test, memcmp(buf, result->expected, dst_size), 0); 600 + KUNIT_EXPECT_MEMEQ(test, buf, result->expected, dst_size); 601 601 } 602 602 603 603 static void drm_test_fb_xrgb8888_to_argb1555(struct kunit *test) ··· 628 628 629 629 drm_fb_xrgb8888_to_argb1555(&dst, &result->dst_pitch, &src, &fb, &params->clip); 630 630 buf = le16buf_to_cpu(test, (__force const __le16 *)buf, dst_size / sizeof(__le16)); 631 - KUNIT_EXPECT_EQ(test, memcmp(buf, result->expected, dst_size), 0); 631 + KUNIT_EXPECT_MEMEQ(test, buf, result->expected, dst_size); 632 632 } 633 633 634 634 static void drm_test_fb_xrgb8888_to_rgba5551(struct kunit *test) ··· 659 659 660 660 drm_fb_xrgb8888_to_rgba5551(&dst, &result->dst_pitch, &src, &fb, &params->clip); 661 661 buf = le16buf_to_cpu(test, (__force const __le16 *)buf, dst_size / sizeof(__le16)); 662 - KUNIT_EXPECT_EQ(test, memcmp(buf, result->expected, dst_size), 0); 662 + KUNIT_EXPECT_MEMEQ(test, buf, result->expected, dst_size); 663 663 } 664 664 665 665 static void drm_test_fb_xrgb8888_to_rgb888(struct kunit *test) ··· 724 724 725 725 drm_fb_xrgb8888_to_argb8888(&dst, &result->dst_pitch, &src, &fb, &params->clip); 726 726 buf = le32buf_to_cpu(test, (__force const __le32 *)buf, dst_size / sizeof(u32)); 727 - KUNIT_EXPECT_EQ(test, memcmp(buf, result->expected, dst_size), 0); 727 + KUNIT_EXPECT_MEMEQ(test, buf, result->expected, dst_size); 728 728 } 729 729 730 730 static void drm_test_fb_xrgb8888_to_xrgb2101010(struct kunit *test) ··· 786 786 787 787 drm_fb_xrgb8888_to_argb2101010(&dst, &result->dst_pitch, &src, &fb, &params->clip); 788 788 buf = le32buf_to_cpu(test, (__force const __le32 *)buf, dst_size / sizeof(u32)); 789 - KUNIT_EXPECT_EQ(test, memcmp(buf, result->expected, dst_size), 0); 789 + KUNIT_EXPECT_MEMEQ(test, buf, result->expected, dst_size); 790 790 } 791 791 792 792 static struct kunit_case drm_format_helper_test_cases[] = {