Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

libata: Align ata_device's id on a cacheline

The id buffer in ata_device is a DMA target, but it isn't explicitly
cacheline aligned. Due to this, adjacent fields can be overwritten with
stale data from memory on non coherent architectures. As a result, the
kernel is sometimes unable to communicate with an ATA device.

Fix this by ensuring that the id buffer is cacheline aligned.

This issue is similar to that fixed by Commit 84bda12af31f
("libata: align ap->sector_buf").

Signed-off-by: Harvey Hunt <harvey.hunt@imgtec.com>
Cc: linux-kernel@vger.kernel.org
Cc: <stable@vger.kernel.org> # 2.6.18
Signed-off-by: Tejun Heo <tj@kernel.org>

authored by

Harvey Hunt and committed by
Tejun Heo
4ee34ea3 f5bdd66c

+1 -1
+1 -1
include/linux/libata.h
··· 720 720 union { 721 721 u16 id[ATA_ID_WORDS]; /* IDENTIFY xxx DEVICE data */ 722 722 u32 gscr[SATA_PMP_GSCR_DWORDS]; /* PMP GSCR block */ 723 - }; 723 + } ____cacheline_aligned; 724 724 725 725 /* DEVSLP Timing Variables from Identify Device Data Log */ 726 726 u8 devslp_timing[ATA_LOG_DEVSLP_SIZE];