Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

NFS: Convert use of __constant_htonl to htonl

In little endian cases, the macro htonl unfolds to __swab32 which
provides special case for constants. In big endian cases,
__constant_htonl and htonl expand directly to the same expression.
So, replace __constant_htonl with htonl with the goal of getting
rid of the definition of __constant_htonl completely.

The semantic patch that performs this transformation is as follows:

@@expression x;@@

- __constant_htonl(x)
+ htonl(x)

Signed-off-by: Vaishali Thakkar <vthakkar1994@gmail.com>
Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com>

authored by

Vaishali Thakkar and committed by
Trond Myklebust
4ed0d83d 4a068258

+1 -1
+1 -1
fs/nfs/callback_xdr.c
··· 909 909 xdr_init_encode(&xdr_out, &rqstp->rq_res, p); 910 910 911 911 status = decode_compound_hdr_arg(&xdr_in, &hdr_arg); 912 - if (status == __constant_htonl(NFS4ERR_RESOURCE)) 912 + if (status == htonl(NFS4ERR_RESOURCE)) 913 913 return rpc_garbage_args; 914 914 915 915 if (hdr_arg.minorversion == 0) {