Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

preempt: Use preempt_schedule_context() as the official tracing preemption point

preempt_schedule_context() is a tracing safe preemption point but it's
only used when CONFIG_CONTEXT_TRACKING=y. Other configs have tracing
recursion issues since commit:

b30f0e3ffedf ("sched/preempt: Optimize preemption operations on __schedule() callers")

introduced function based preemp_count_*() ops.

Lets make it available on all configs and give it a more appropriate
name for its new position.

Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/1433432349-1021-3-git-send-email-fweisbec@gmail.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>

authored by

Frederic Weisbecker and committed by
Ingo Molnar
4eaca0a8 be690035

+13 -32
+3 -5
arch/x86/include/asm/preempt.h
··· 99 99 extern asmlinkage void ___preempt_schedule(void); 100 100 # define __preempt_schedule() asm ("call ___preempt_schedule") 101 101 extern asmlinkage void preempt_schedule(void); 102 - # ifdef CONFIG_CONTEXT_TRACKING 103 - extern asmlinkage void ___preempt_schedule_context(void); 104 - # define __preempt_schedule_context() asm ("call ___preempt_schedule_context") 105 - extern asmlinkage void preempt_schedule_context(void); 106 - # endif 102 + extern asmlinkage void ___preempt_schedule_notrace(void); 103 + # define __preempt_schedule_notrace() asm ("call ___preempt_schedule_notrace") 104 + extern asmlinkage void preempt_schedule_notrace(void); 107 105 #endif 108 106 109 107 #endif /* __ASM_PREEMPT_H */
+1 -3
arch/x86/kernel/i386_ksyms_32.c
··· 40 40 41 41 #ifdef CONFIG_PREEMPT 42 42 EXPORT_SYMBOL(___preempt_schedule); 43 - #ifdef CONFIG_CONTEXT_TRACKING 44 - EXPORT_SYMBOL(___preempt_schedule_context); 45 - #endif 43 + EXPORT_SYMBOL(___preempt_schedule_notrace); 46 44 #endif
+1 -3
arch/x86/kernel/x8664_ksyms_64.c
··· 75 75 76 76 #ifdef CONFIG_PREEMPT 77 77 EXPORT_SYMBOL(___preempt_schedule); 78 - #ifdef CONFIG_CONTEXT_TRACKING 79 - EXPORT_SYMBOL(___preempt_schedule_context); 80 - #endif 78 + EXPORT_SYMBOL(___preempt_schedule_notrace); 81 79 #endif
+1 -3
arch/x86/lib/thunk_32.S
··· 38 38 39 39 #ifdef CONFIG_PREEMPT 40 40 THUNK ___preempt_schedule, preempt_schedule 41 - #ifdef CONFIG_CONTEXT_TRACKING 42 - THUNK ___preempt_schedule_context, preempt_schedule_context 43 - #endif 41 + THUNK ___preempt_schedule_notrace, preempt_schedule_notrace 44 42 #endif 45 43
+1 -3
arch/x86/lib/thunk_64.S
··· 49 49 50 50 #ifdef CONFIG_PREEMPT 51 51 THUNK ___preempt_schedule, preempt_schedule 52 - #ifdef CONFIG_CONTEXT_TRACKING 53 - THUNK ___preempt_schedule_context, preempt_schedule_context 54 - #endif 52 + THUNK ___preempt_schedule_notrace, preempt_schedule_notrace 55 53 #endif 56 54 57 55 #if defined(CONFIG_TRACE_IRQFLAGS) \
+2 -5
include/asm-generic/preempt.h
··· 79 79 #ifdef CONFIG_PREEMPT 80 80 extern asmlinkage void preempt_schedule(void); 81 81 #define __preempt_schedule() preempt_schedule() 82 - 83 - #ifdef CONFIG_CONTEXT_TRACKING 84 - extern asmlinkage void preempt_schedule_context(void); 85 - #define __preempt_schedule_context() preempt_schedule_context() 86 - #endif 82 + extern asmlinkage void preempt_schedule_notrace(void); 83 + #define __preempt_schedule_notrace() preempt_schedule_notrace() 87 84 #endif /* CONFIG_PREEMPT */ 88 85 89 86 #endif /* __ASM_PREEMPT_H */
+1 -5
include/linux/preempt.h
··· 204 204 205 205 #ifdef CONFIG_PREEMPT 206 206 207 - #ifndef CONFIG_CONTEXT_TRACKING 208 - #define __preempt_schedule_context() __preempt_schedule() 209 - #endif 210 - 211 207 #define preempt_enable_notrace() \ 212 208 do { \ 213 209 barrier(); \ 214 210 if (unlikely(__preempt_count_dec_and_test())) \ 215 - __preempt_schedule_context(); \ 211 + __preempt_schedule_notrace(); \ 216 212 } while (0) 217 213 #else 218 214 #define preempt_enable_notrace() \
+3 -5
kernel/sched/core.c
··· 2937 2937 NOKPROBE_SYMBOL(preempt_schedule); 2938 2938 EXPORT_SYMBOL(preempt_schedule); 2939 2939 2940 - #ifdef CONFIG_CONTEXT_TRACKING 2941 2940 /** 2942 - * preempt_schedule_context - preempt_schedule called by tracing 2941 + * preempt_schedule_notrace - preempt_schedule called by tracing 2943 2942 * 2944 2943 * The tracing infrastructure uses preempt_enable_notrace to prevent 2945 2944 * recursion and tracing preempt enabling caused by the tracing ··· 2951 2952 * instead of preempt_schedule() to exit user context if needed before 2952 2953 * calling the scheduler. 2953 2954 */ 2954 - asmlinkage __visible void __sched notrace preempt_schedule_context(void) 2955 + asmlinkage __visible void __sched notrace preempt_schedule_notrace(void) 2955 2956 { 2956 2957 enum ctx_state prev_ctx; 2957 2958 ··· 2979 2980 __preempt_count_sub(PREEMPT_ACTIVE + PREEMPT_DISABLE_OFFSET); 2980 2981 } while (need_resched()); 2981 2982 } 2982 - EXPORT_SYMBOL_GPL(preempt_schedule_context); 2983 - #endif /* CONFIG_CONTEXT_TRACKING */ 2983 + EXPORT_SYMBOL_GPL(preempt_schedule_notrace); 2984 2984 2985 2985 #endif /* CONFIG_PREEMPT */ 2986 2986