Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

net: dsa: mv88e6xxx: fix broken if statement because of a stray semicolon

There is a stray semicolon in an if statement that will cause a dev_err
message to be printed unconditionally. Fix this by removing the stray
semicolon.

Addresses-Coverity: ("Stay semicolon")
Fixes: f0942e00a1ab ("net: dsa: mv88e6xxx: Add support for port mirroring")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>

authored by

Colin Ian King and committed by
David S. Miller
4e4637b1 084346be

+1 -1
+1 -1
drivers/net/dsa/mv88e6xxx/chip.c
··· 5317 5317 if (chip->info->ops->set_egress_port(chip, 5318 5318 direction, 5319 5319 dsa_upstream_port(ds, 5320 - port))); 5320 + port))) 5321 5321 dev_err(ds->dev, "failed to set egress port\n"); 5322 5322 } 5323 5323