Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

misc: lis3lv02d: Make lis3lv02d_remove_fs() return void

Up to now lis3lv02d_remove_fs() returns zero unconditionally. Make it return
void instead which makes it easier to see in the callers that there is
no error to handle.

Also the return value of i2c and spi remove callbacks is ignored anyway.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20211012153945.2651412-13-u.kleine-koenig@pengutronix.de
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

authored by

Uwe Kleine-König and committed by
Greg Kroah-Hartman
4df4946d 424f1ac2

+7 -5
+1 -2
drivers/misc/lis3lv02d/lis3lv02d.c
··· 878 878 return sysfs_create_group(&lis3->pdev->dev.kobj, &lis3lv02d_attribute_group); 879 879 } 880 880 881 - int lis3lv02d_remove_fs(struct lis3lv02d *lis3) 881 + void lis3lv02d_remove_fs(struct lis3lv02d *lis3) 882 882 { 883 883 sysfs_remove_group(&lis3->pdev->dev.kobj, &lis3lv02d_attribute_group); 884 884 platform_device_unregister(lis3->pdev); ··· 894 894 pm_runtime_set_suspended(lis3->pm_dev); 895 895 } 896 896 kfree(lis3->reg_cache); 897 - return 0; 898 897 } 899 898 EXPORT_SYMBOL_GPL(lis3lv02d_remove_fs); 900 899
+1 -1
drivers/misc/lis3lv02d/lis3lv02d.h
··· 312 312 void lis3lv02d_joystick_disable(struct lis3lv02d *lis3); 313 313 void lis3lv02d_poweroff(struct lis3lv02d *lis3); 314 314 int lis3lv02d_poweron(struct lis3lv02d *lis3); 315 - int lis3lv02d_remove_fs(struct lis3lv02d *lis3); 315 + void lis3lv02d_remove_fs(struct lis3lv02d *lis3); 316 316 int lis3lv02d_init_dt(struct lis3lv02d *lis3); 317 317 318 318 extern struct lis3lv02d lis3_dev;
+3 -1
drivers/misc/lis3lv02d/lis3lv02d_spi.c
··· 102 102 lis3lv02d_joystick_disable(lis3); 103 103 lis3lv02d_poweroff(lis3); 104 104 105 - return lis3lv02d_remove_fs(&lis3_dev); 105 + lis3lv02d_remove_fs(&lis3_dev); 106 + 107 + return 0; 106 108 } 107 109 108 110 #ifdef CONFIG_PM_SLEEP
+2 -1
drivers/platform/x86/hp_accel.c
··· 349 349 led_classdev_unregister(&hpled_led.led_classdev); 350 350 flush_work(&hpled_led.work); 351 351 352 - return lis3lv02d_remove_fs(&lis3_dev); 352 + lis3lv02d_remove_fs(&lis3_dev); 353 + return 0; 353 354 } 354 355 355 356 #ifdef CONFIG_PM_SLEEP