Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

mfd: smsc-ece1099: Return directly after a function failure in smsc_i2c_probe()

This issue was detected by using the Coccinelle software.

Return directly if a call of the function "devm_regmap_init_i2c"
or "regmap_write" failed.

Delete the jump label "err" then.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Lee Jones <lee.jones@linaro.org>

authored by

Markus Elfring and committed by
Lee Jones
4dc03d0a 53b34b8d

+3 -6
+3 -6
drivers/mfd/smsc-ece1099.c
··· 46 46 } 47 47 48 48 smsc->regmap = devm_regmap_init_i2c(i2c, &smsc_regmap_config); 49 - if (IS_ERR(smsc->regmap)) { 50 - ret = PTR_ERR(smsc->regmap); 51 - goto err; 52 - } 49 + if (IS_ERR(smsc->regmap)) 50 + return PTR_ERR(smsc->regmap); 53 51 54 52 i2c_set_clientdata(i2c, smsc); 55 53 smsc->dev = &i2c->dev; ··· 66 68 67 69 ret = regmap_write(smsc->regmap, SMSC_CLK_CTRL, smsc->clk); 68 70 if (ret) 69 - goto err; 71 + return ret; 70 72 71 73 #ifdef CONFIG_OF 72 74 if (i2c->dev.of_node) ··· 74 76 NULL, NULL, &i2c->dev); 75 77 #endif 76 78 77 - err: 78 79 return ret; 79 80 } 80 81