Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

scsi: libfcoe: Replace all non-returning strlcpy() with strscpy()

strlcpy() reads the entire source buffer first. This read may exceed the
destination size limit. This is both inefficient and can lead to linear
read overflows if a source string is not NUL-terminated [1]. In an effort
to remove strlcpy() completely [2], replace strlcpy() here with strscpy().
No return values were used, so direct replacement is safe.

[1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy
[2] https://github.com/KSPP/linux/issues/89

Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com>
Link: https://lore.kernel.org/r/20230530155818.368562-1-azeemshaikh38@gmail.com
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

authored by

Azeem Shaikh and committed by
Martin K. Petersen
4dae0262 73be26b1

+1 -1
+1 -1
drivers/scsi/fcoe/fcoe_transport.c
··· 711 711 char ifname[IFNAMSIZ + 2]; 712 712 713 713 if (buffer) { 714 - strlcpy(ifname, buffer, IFNAMSIZ); 714 + strscpy(ifname, buffer, IFNAMSIZ); 715 715 cp = ifname + strlen(ifname); 716 716 while (--cp >= ifname && *cp == '\n') 717 717 *cp = '\0';