Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

[SCSI] sun3: Remove commented out merge_contiguous_buffers

This fixes:

drivers/scsi/sun3_NCR5380.c:475: warning: ‘merge_contiguous_buffers’ defined but not used

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Sam Creasey <sammy@sammy.net>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>

authored by

Geert Uytterhoeven and committed by
James Bottomley
4d08e731 2ba51ea2

-58
-58
drivers/scsi/sun3_NCR5380.c
··· 49 49 * inside the execution of NCR5380_intr(), leading to recursive 50 50 * calls. 51 51 * 52 - * - I've added a function merge_contiguous_buffers() that tries to 53 - * merge scatter-gather buffers that are located at contiguous 54 - * physical addresses and can be processed with the same DMA setup. 55 - * Since most scatter-gather operations work on a page (4K) of 56 - * 4 buffers (1K), in more than 90% of all cases three interrupts and 57 - * DMA setup actions are saved. 58 - * 59 52 * - I've deleted all the stuff for AUTOPROBE_IRQ, REAL_DMA_POLL, PSEUDO_DMA 60 53 * and USLEEP, because these were messing up readability and will never be 61 54 * needed for Atari SCSI. ··· 453 460 454 461 455 462 /* 456 - * Function: void merge_contiguous_buffers(struct scsi_cmnd *cmd) 457 - * 458 - * Purpose: Try to merge several scatter-gather requests into one DMA 459 - * transfer. This is possible if the scatter buffers lie on 460 - * physical contiguous addresses. 461 - * 462 - * Parameters: struct scsi_cmnd *cmd 463 - * The command to work on. The first scatter buffer's data are 464 - * assumed to be already transferred into ptr/this_residual. 465 - */ 466 - 467 - static void merge_contiguous_buffers(struct scsi_cmnd *cmd) 468 - { 469 - unsigned long endaddr; 470 - #if (NDEBUG & NDEBUG_MERGING) 471 - unsigned long oldlen = cmd->SCp.this_residual; 472 - int cnt = 1; 473 - #endif 474 - 475 - for (endaddr = virt_to_phys(cmd->SCp.ptr + cmd->SCp.this_residual - 1) + 1; 476 - cmd->SCp.buffers_residual && 477 - virt_to_phys(SGADDR(&(cmd->SCp.buffer[1]))) == endaddr; ) { 478 - 479 - MER_PRINTK("VTOP(%p) == %08lx -> merging\n", 480 - SGADDR(&(cmd->SCp.buffer[1])), endaddr); 481 - #if (NDEBUG & NDEBUG_MERGING) 482 - ++cnt; 483 - #endif 484 - ++cmd->SCp.buffer; 485 - --cmd->SCp.buffers_residual; 486 - cmd->SCp.this_residual += cmd->SCp.buffer->length; 487 - endaddr += cmd->SCp.buffer->length; 488 - } 489 - #if (NDEBUG & NDEBUG_MERGING) 490 - if (oldlen != cmd->SCp.this_residual) 491 - MER_PRINTK("merged %d buffers from %p, new length %08x\n", 492 - cnt, cmd->SCp.ptr, cmd->SCp.this_residual); 493 - #endif 494 - } 495 - 496 - /* 497 463 * Function : void initialize_SCp(struct scsi_cmnd *cmd) 498 464 * 499 465 * Purpose : initialize the saved data pointers for cmd to point to the ··· 473 521 cmd->SCp.buffers_residual = scsi_sg_count(cmd) - 1; 474 522 cmd->SCp.ptr = (char *) SGADDR(cmd->SCp.buffer); 475 523 cmd->SCp.this_residual = cmd->SCp.buffer->length; 476 - 477 - /* ++roman: Try to merge some scatter-buffers if they are at 478 - * contiguous physical addresses. 479 - */ 480 - // merge_contiguous_buffers( cmd ); 481 524 } else { 482 525 cmd->SCp.buffer = NULL; 483 526 cmd->SCp.buffers_residual = 0; ··· 2023 2076 --cmd->SCp.buffers_residual; 2024 2077 cmd->SCp.this_residual = cmd->SCp.buffer->length; 2025 2078 cmd->SCp.ptr = SGADDR(cmd->SCp.buffer); 2026 - 2027 - /* ++roman: Try to merge some scatter-buffers if 2028 - * they are at contiguous physical addresses. 2029 - */ 2030 - // merge_contiguous_buffers( cmd ); 2031 2079 INF_PRINTK("scsi%d: %d bytes and %d buffers left\n", 2032 2080 HOSTNO, cmd->SCp.this_residual, 2033 2081 cmd->SCp.buffers_residual);