Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

EISA: Use dev_printk() when possible

Use dev_printk() when possible to make messages more useful.

Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>

+28 -36
+26 -33
drivers/eisa/eisa-bus.c
··· 314 314 { 315 315 int i, c; 316 316 struct eisa_device *edev; 317 + char *enabled_str; 317 318 318 - printk(KERN_INFO "EISA: Probing bus %d at %s\n", 319 - root->bus_nr, dev_name(root->dev)); 319 + dev_info(root->dev, "Probing EISA bus %d\n", root->bus_nr); 320 320 321 321 /* First try to get hold of slot 0. If there is no device 322 322 * here, simply fail, unless root->force_probe is set. */ 323 323 324 324 edev = kzalloc(sizeof(*edev), GFP_KERNEL); 325 325 if (!edev) { 326 - printk(KERN_ERR "EISA: Couldn't allocate mainboard slot\n"); 326 + dev_err(root->dev, "EISA: Couldn't allocate mainboard slot\n"); 327 327 return -ENOMEM; 328 328 } 329 329 330 330 if (eisa_request_resources(root, edev, 0)) { 331 - printk(KERN_WARNING \ 332 - "EISA: Cannot allocate resource for mainboard\n"); 331 + dev_warn(root->dev, 332 + "EISA: Cannot allocate resource for mainboard\n"); 333 333 kfree(edev); 334 334 if (!root->force_probe) 335 335 return -EBUSY; ··· 344 344 goto force_probe; 345 345 } 346 346 347 - printk(KERN_INFO "EISA: Mainboard %s detected.\n", edev->id.sig); 347 + dev_info(&edev->dev, "EISA: Mainboard %s detected\n", edev->id.sig); 348 348 349 349 if (eisa_register_device(edev)) { 350 - printk(KERN_ERR "EISA: Failed to register %s\n", 351 - edev->id.sig); 350 + dev_err(&edev->dev, "EISA: Failed to register %s\n", 351 + edev->id.sig); 352 352 eisa_release_resources(edev); 353 353 kfree(edev); 354 354 } ··· 358 358 for (c = 0, i = 1; i <= root->slots; i++) { 359 359 edev = kzalloc(sizeof(*edev), GFP_KERNEL); 360 360 if (!edev) { 361 - printk(KERN_ERR "EISA: Out of memory for slot %d\n", i); 361 + dev_err(root->dev, "EISA: Out of memory for slot %d\n", 362 + i); 362 363 continue; 363 364 } 364 365 365 366 if (eisa_request_resources(root, edev, i)) { 366 - printk(KERN_WARNING \ 367 - "Cannot allocate resource for EISA slot %d\n", 368 - i); 367 + dev_warn(root->dev, 368 + "Cannot allocate resource for EISA slot %d\n", 369 + i); 369 370 kfree(edev); 370 371 continue; 371 372 } ··· 376 375 kfree(edev); 377 376 continue; 378 377 } 379 - 380 - printk(KERN_INFO "EISA: slot %d : %s detected", 381 - i, edev->id.sig); 382 - 383 - switch (edev->state) { 384 - case EISA_CONFIG_ENABLED | EISA_CONFIG_FORCED: 385 - printk(" (forced enabled)"); 386 - break; 387 378 388 - case EISA_CONFIG_FORCED: 389 - printk(" (forced disabled)"); 390 - break; 379 + if (edev->state == (EISA_CONFIG_ENABLED | EISA_CONFIG_FORCED)) 380 + enabled_str = " (forced enabled)"; 381 + else if (edev->state == EISA_CONFIG_FORCED) 382 + enabled_str = " (forced disabled)"; 383 + else if (edev->state == 0) 384 + enabled_str = " (disabled)"; 385 + else 386 + enabled_str = ""; 391 387 392 - case 0: 393 - printk(" (disabled)"); 394 - break; 395 - } 396 - 397 - printk (".\n"); 388 + dev_info(&edev->dev, "EISA: slot %d: %s detected%s\n", i, 389 + edev->id.sig, enabled_str); 398 390 399 391 c++; 400 392 401 393 if (eisa_register_device(edev)) { 402 - printk(KERN_ERR "EISA: Failed to register %s\n", 403 - edev->id.sig); 394 + dev_err(&edev->dev, "EISA: Failed to register %s\n", 395 + edev->id.sig); 404 396 eisa_release_resources(edev); 405 397 kfree(edev); 406 398 } 407 399 } 408 400 409 - printk(KERN_INFO "EISA: Detected %d card%s.\n", c, c == 1 ? "" : "s"); 410 - 401 + dev_info(root->dev, "EISA: Detected %d card%s\n", c, c == 1 ? "" : "s"); 411 402 return 0; 412 403 } 413 404
+2 -3
drivers/eisa/pci_eisa.c
··· 25 25 int rc; 26 26 27 27 if ((rc = pci_enable_device (pdev))) { 28 - printk (KERN_ERR "pci_eisa : Could not enable device %s\n", 29 - pci_name(pdev)); 28 + dev_err(&pdev->dev, "Could not enable device\n"); 30 29 return rc; 31 30 } 32 31 ··· 37 38 dev_set_drvdata(pci_eisa_root.dev, &pci_eisa_root); 38 39 39 40 if (eisa_root_register (&pci_eisa_root)) { 40 - printk (KERN_ERR "pci_eisa : Could not register EISA root\n"); 41 + dev_err(&pdev->dev, "Could not register EISA root\n"); 41 42 return -1; 42 43 } 43 44