Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

staging: bcm2835-camera: Add hint about possible faulty config

As per default the GPU memory config of the Raspberry Pi isn't sufficient
for the camera usage. Even worse the bcm2835 camera driver doesn't provide a
helpful error message in this case. So let's add a hint to point the user
to the likely cause.

Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
Reviewed-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

authored by

Stefan Wahren and committed by
Greg Kroah-Hartman
4cc357c5 9c85a4d0

+4 -1
+4 -1
drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c
··· 1623 1623 component = &instance->component[instance->component_idx]; 1624 1624 1625 1625 ret = create_component(instance, component, name); 1626 - if (ret < 0) 1626 + if (ret < 0) { 1627 + pr_err("%s: failed to create component %d (Not enough GPU mem?)\n", 1628 + __func__, ret); 1627 1629 goto unlock; 1630 + } 1628 1631 1629 1632 /* ports info needs gathering */ 1630 1633 component->control.type = MMAL_PORT_TYPE_CONTROL;