Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

power: supply: rx51: Use devm_power_supply_register() helper

Use the device lifecycle managed register function. This helps prevent
mistakes like unregistering out of order in cleanup functions and
forgetting to unregister on error paths.

Signed-off-by: Andrew Davis <afd@ti.com>
Link: https://lore.kernel.org/r/20240123163653.384385-20-afd@ti.com
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>

authored by

Andrew Davis and committed by
Sebastian Reichel
4cb372a0 a16dc57e

+1 -11
+1 -11
drivers/power/supply/rx51_battery.c
··· 197 197 if (!di) 198 198 return -ENOMEM; 199 199 200 - platform_set_drvdata(pdev, di); 201 - 202 200 di->dev = &pdev->dev; 203 201 di->bat_desc.name = "rx51-battery"; 204 202 di->bat_desc.type = POWER_SUPPLY_TYPE_BATTERY; ··· 218 220 if (IS_ERR(di->channel_vbat)) 219 221 return PTR_ERR(di->channel_vbat); 220 222 221 - di->bat = power_supply_register(di->dev, &di->bat_desc, &psy_cfg); 223 + di->bat = devm_power_supply_register(di->dev, &di->bat_desc, &psy_cfg); 222 224 if (IS_ERR(di->bat)) 223 225 return PTR_ERR(di->bat); 224 226 225 227 return 0; 226 - } 227 - 228 - static void rx51_battery_remove(struct platform_device *pdev) 229 - { 230 - struct rx51_device_info *di = platform_get_drvdata(pdev); 231 - 232 - power_supply_unregister(di->bat); 233 228 } 234 229 235 230 #ifdef CONFIG_OF ··· 235 244 236 245 static struct platform_driver rx51_battery_driver = { 237 246 .probe = rx51_battery_probe, 238 - .remove_new = rx51_battery_remove, 239 247 .driver = { 240 248 .name = "rx51-battery", 241 249 .of_match_table = of_match_ptr(n900_battery_of_match),