Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

farsync: switch from 'pci_' to 'dma_' API

The wrappers in include/linux/pci-dma-compat.h should go away.

The patch has been generated with the coccinelle script below and has been
hand modified to replace GFP_ with a correct flag.
It has been compile tested.

When memory is allocated in 'fst_add_one()', GFP_KERNEL can be used
because it is a probe function and no lock is acquired.

@@
@@
- PCI_DMA_BIDIRECTIONAL
+ DMA_BIDIRECTIONAL

@@
@@
- PCI_DMA_TODEVICE
+ DMA_TO_DEVICE

@@
@@
- PCI_DMA_FROMDEVICE
+ DMA_FROM_DEVICE

@@
@@
- PCI_DMA_NONE
+ DMA_NONE

@@
expression e1, e2, e3;
@@
- pci_alloc_consistent(e1, e2, e3)
+ dma_alloc_coherent(&e1->dev, e2, e3, GFP_)

@@
expression e1, e2, e3;
@@
- pci_zalloc_consistent(e1, e2, e3)
+ dma_alloc_coherent(&e1->dev, e2, e3, GFP_)

@@
expression e1, e2, e3, e4;
@@
- pci_free_consistent(e1, e2, e3, e4)
+ dma_free_coherent(&e1->dev, e2, e3, e4)

@@
expression e1, e2, e3, e4;
@@
- pci_map_single(e1, e2, e3, e4)
+ dma_map_single(&e1->dev, e2, e3, e4)

@@
expression e1, e2, e3, e4;
@@
- pci_unmap_single(e1, e2, e3, e4)
+ dma_unmap_single(&e1->dev, e2, e3, e4)

@@
expression e1, e2, e3, e4, e5;
@@
- pci_map_page(e1, e2, e3, e4, e5)
+ dma_map_page(&e1->dev, e2, e3, e4, e5)

@@
expression e1, e2, e3, e4;
@@
- pci_unmap_page(e1, e2, e3, e4)
+ dma_unmap_page(&e1->dev, e2, e3, e4)

@@
expression e1, e2, e3, e4;
@@
- pci_map_sg(e1, e2, e3, e4)
+ dma_map_sg(&e1->dev, e2, e3, e4)

@@
expression e1, e2, e3, e4;
@@
- pci_unmap_sg(e1, e2, e3, e4)
+ dma_unmap_sg(&e1->dev, e2, e3, e4)

@@
expression e1, e2, e3, e4;
@@
- pci_dma_sync_single_for_cpu(e1, e2, e3, e4)
+ dma_sync_single_for_cpu(&e1->dev, e2, e3, e4)

@@
expression e1, e2, e3, e4;
@@
- pci_dma_sync_single_for_device(e1, e2, e3, e4)
+ dma_sync_single_for_device(&e1->dev, e2, e3, e4)

@@
expression e1, e2, e3, e4;
@@
- pci_dma_sync_sg_for_cpu(e1, e2, e3, e4)
+ dma_sync_sg_for_cpu(&e1->dev, e2, e3, e4)

@@
expression e1, e2, e3, e4;
@@
- pci_dma_sync_sg_for_device(e1, e2, e3, e4)
+ dma_sync_sg_for_device(&e1->dev, e2, e3, e4)

@@
expression e1, e2;
@@
- pci_dma_mapping_error(e1, e2)
+ dma_mapping_error(&e1->dev, e2)

@@
expression e1, e2;
@@
- pci_set_dma_mask(e1, e2)
+ dma_set_mask(&e1->dev, e2)

@@
expression e1, e2;
@@
- pci_set_consistent_dma_mask(e1, e2)
+ dma_set_coherent_mask(&e1->dev, e2)

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: David S. Miller <davem@davemloft.net>

authored by

Christophe JAILLET and committed by
David S. Miller
4c900a6b 24dd377a

+12 -13
+12 -13
drivers/net/wan/farsync.c
··· 2553 2553 * Allocate a dma buffer for transmit and receives 2554 2554 */ 2555 2555 card->rx_dma_handle_host = 2556 - pci_alloc_consistent(card->device, FST_MAX_MTU, 2557 - &card->rx_dma_handle_card); 2556 + dma_alloc_coherent(&card->device->dev, FST_MAX_MTU, 2557 + &card->rx_dma_handle_card, GFP_KERNEL); 2558 2558 if (card->rx_dma_handle_host == NULL) { 2559 2559 pr_err("Could not allocate rx dma buffer\n"); 2560 2560 err = -ENOMEM; 2561 2561 goto rx_dma_fail; 2562 2562 } 2563 2563 card->tx_dma_handle_host = 2564 - pci_alloc_consistent(card->device, FST_MAX_MTU, 2565 - &card->tx_dma_handle_card); 2564 + dma_alloc_coherent(&card->device->dev, FST_MAX_MTU, 2565 + &card->tx_dma_handle_card, GFP_KERNEL); 2566 2566 if (card->tx_dma_handle_host == NULL) { 2567 2567 pr_err("Could not allocate tx dma buffer\n"); 2568 2568 err = -ENOMEM; ··· 2572 2572 return 0; /* Success */ 2573 2573 2574 2574 tx_dma_fail: 2575 - pci_free_consistent(card->device, FST_MAX_MTU, 2576 - card->rx_dma_handle_host, 2577 - card->rx_dma_handle_card); 2575 + dma_free_coherent(&card->device->dev, FST_MAX_MTU, 2576 + card->rx_dma_handle_host, card->rx_dma_handle_card); 2578 2577 rx_dma_fail: 2579 2578 fst_disable_intr(card); 2580 2579 for (i = 0 ; i < card->nports ; i++) ··· 2624 2625 /* 2625 2626 * Free dma buffers 2626 2627 */ 2627 - pci_free_consistent(card->device, FST_MAX_MTU, 2628 - card->rx_dma_handle_host, 2629 - card->rx_dma_handle_card); 2630 - pci_free_consistent(card->device, FST_MAX_MTU, 2631 - card->tx_dma_handle_host, 2632 - card->tx_dma_handle_card); 2628 + dma_free_coherent(&card->device->dev, FST_MAX_MTU, 2629 + card->rx_dma_handle_host, 2630 + card->rx_dma_handle_card); 2631 + dma_free_coherent(&card->device->dev, FST_MAX_MTU, 2632 + card->tx_dma_handle_host, 2633 + card->tx_dma_handle_card); 2633 2634 } 2634 2635 fst_card_array[card->card_no] = NULL; 2635 2636 }