Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

[media] mxl111sf: fix a couple precedence bugs

Negate has higher precedence than bitwise AND. I2C_M_RD is 0x1 so
the original code is equivelent to just checking if (!msg->flags).

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Steven Toth <stoth@kernellabs.com>
Cc: Michael Krufky <mkrufky@kernellabs.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

authored by

Dan Carpenter and committed by
Mauro Carvalho Chehab
4c4364e0 446b792c

+2 -2
+2 -2
drivers/media/dvb/dvb-usb/mxl111sf-i2c.c
··· 453 453 454 454 mxl_i2c("addr: 0x%02x, read buff len: %d, write buff len: %d", 455 455 msg->addr, (msg->flags & I2C_M_RD) ? msg->len : 0, 456 - (!msg->flags & I2C_M_RD) ? msg->len : 0); 456 + (!(msg->flags & I2C_M_RD)) ? msg->len : 0); 457 457 458 458 for (index = 0; index < 26; index++) 459 459 buf[index] = USB_END_I2C_CMD; ··· 489 489 ret = mxl111sf_i2c_send_data(state, 0, buf); 490 490 491 491 /* write data on I2C bus */ 492 - if ((!msg->flags & I2C_M_RD) && (msg->len > 0)) { 492 + if (!(msg->flags & I2C_M_RD) && (msg->len > 0)) { 493 493 mxl_i2c("%d\t%02x", msg->len, msg->buf[0]); 494 494 495 495 /* control register on I2C interface to initialize I2C bus */