Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

cpufreq: pcc: Fix the potentinal scheduling delays in target_index()

pcc_cpufreq_target():
cpufreq_freq_transition_begin();
spin_lock(&pcc_lock);
[critical section]
cpufreq_freq_transition_end();
spin_unlock(&pcc_lock);

Above code has a performance issue, consider that Task0 executes
'cpufreq_freq_transition_end()' to wake Task1 and preempted imediatedly
without releasing 'pcc_lock', then Task1 needs to wait for Task0 to
release 'pcc_lock'. In the worst case, this locking order can result in
Task1 wasting two scheduling rounds before it can enter the critical
section.

Signed-off-by: Liao Chang <liaochang1@huawei.com>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

authored by

Liao Chang and committed by
Rafael J. Wysocki
4c2fdf73 916f1388

+1 -1
+1 -1
drivers/cpufreq/pcc-cpufreq.c
··· 232 232 status = ioread16(&pcch_hdr->status); 233 233 iowrite16(0, &pcch_hdr->status); 234 234 235 - cpufreq_freq_transition_end(policy, &freqs, status != CMD_COMPLETE); 236 235 spin_unlock(&pcc_lock); 236 + cpufreq_freq_transition_end(policy, &freqs, status != CMD_COMPLETE); 237 237 238 238 if (status != CMD_COMPLETE) { 239 239 pr_debug("target: FAILED for cpu %d, with status: 0x%x\n",