Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

memory: stm32-fmc2-ebi: simplify with dev_err_probe()

dev_err_probe() combines 'return' and error code printing, thus code is
a bit simpler, even if it cannot actually defer.

Suggested-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Link: https://lore.kernel.org/r/20240816-cleanup-h-of-node-put-memory-v2-6-9eed0ee16b78@linaro.org
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

+5 -10
+5 -10
drivers/memory/stm32-fmc2-ebi.c
··· 1579 1579 1580 1580 for_each_available_child_of_node_scoped(dev->of_node, child) { 1581 1581 ret = of_property_read_u32(child, "reg", &bank); 1582 - if (ret) { 1583 - dev_err(dev, "could not retrieve reg property: %d\n", 1584 - ret); 1585 - return ret; 1586 - } 1582 + if (ret) 1583 + return dev_err_probe(dev, ret, "could not retrieve reg property\n"); 1587 1584 1588 1585 if (bank >= FMC2_MAX_BANKS) { 1589 1586 dev_err(dev, "invalid reg value: %d\n", bank); ··· 1602 1605 1603 1606 if (bank < FMC2_MAX_EBI_CE) { 1604 1607 ret = stm32_fmc2_ebi_setup_cs(ebi, child, bank); 1605 - if (ret) { 1606 - dev_err(dev, "setup chip select %d failed: %d\n", 1607 - bank, ret); 1608 - return ret; 1609 - } 1608 + if (ret) 1609 + return dev_err_probe(dev, ret, 1610 + "setup chip select %d failed\n", bank); 1610 1611 } 1611 1612 1612 1613 ebi->bank_assigned |= BIT(bank);