Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

USB: serial: kobil_sct: restore initial terminal settings

Commit 6a6c8b362be3 ("usb, kobil: Sort out some bogus tty handling")
intended to fix and clean up the device-specific initial terminal
settings but instead confused the termios input and local control flags
and re-enabled ICRNL and IXON.

Drop the bogus masking of l-flags from the default i-flags (which has no
effect) and restore the original device-specific i-flags.

Fixes: 6a6c8b362be3 ("usb, kobil: Sort out some bogus tty handling")
Signed-off-by: Johan Hovold <johan@kernel.org>

+1 -2
+1 -2
drivers/usb/serial/kobil_sct.c
··· 155 155 { 156 156 /* Default to echo off and other sane device settings */ 157 157 tty->termios.c_lflag = 0; 158 - tty->termios.c_iflag &= ~(ISIG | ICANON | ECHO | IEXTEN | XCASE); 159 - tty->termios.c_iflag |= IGNBRK | IGNPAR | IXOFF; 158 + tty->termios.c_iflag = IGNBRK | IGNPAR | IXOFF; 160 159 /* do NOT translate CR to CR-NL (0x0A -> 0x0A 0x0D) */ 161 160 tty->termios.c_oflag &= ~ONLCR; 162 161 }