Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

HID: picoLCD: Deletion of unnecessary checks before three function calls

The functions backlight_device_unregister(), lcd_device_unregister() and
rc_unregister_device() test whether their argument is NULL and then
return immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Reviewed-by: Bruno Prémont <bonbons@linux-vserver.org>
Signed-off-by: Jiri Kosina <jkosina@suse.com>

authored by

Markus Elfring and committed by
Jiri Kosina
4b8a8262 67db8a80

+3 -6
+1 -2
drivers/hid/hid-picolcd_backlight.c
··· 94 94 struct backlight_device *bdev = data->backlight; 95 95 96 96 data->backlight = NULL; 97 - if (bdev) 98 - backlight_device_unregister(bdev); 97 + backlight_device_unregister(bdev); 99 98 } 100 99 101 100 int picolcd_resume_backlight(struct picolcd_data *data)
+1 -2
drivers/hid/hid-picolcd_cir.c
··· 145 145 struct rc_dev *rdev = data->rc_dev; 146 146 147 147 data->rc_dev = NULL; 148 - if (rdev) 149 - rc_unregister_device(rdev); 148 + rc_unregister_device(rdev); 150 149 } 151 150
+1 -2
drivers/hid/hid-picolcd_lcd.c
··· 92 92 struct lcd_device *ldev = data->lcd; 93 93 94 94 data->lcd = NULL; 95 - if (ldev) 96 - lcd_device_unregister(ldev); 95 + lcd_device_unregister(ldev); 97 96 } 98 97 99 98 int picolcd_resume_lcd(struct picolcd_data *data)