Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

perf metrics: Remove the "No_group" metric group

Rather than place metrics without a metric group in "No_group" place
them in a a metric group that is their name. Still allow such metrics
to be selected if "No_group" is passed, this change just impacts perf
list.

Reviewed-by: Kan Liang <kan.liang@linux.intel.com>
Signed-off-by: Ian Rogers <irogers@google.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: https://lore.kernel.org/r/20240403164636.3429091-1-irogers@google.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

authored by

Ian Rogers and committed by
Arnaldo Carvalho de Melo
4b5ee6db 0235abd8

+2 -2
+2 -2
tools/perf/util/metricgroup.c
··· 455 455 const char *g; 456 456 char *omg, *mg; 457 457 458 - mg = strdup(pm->metric_group ?: "No_group"); 458 + mg = strdup(pm->metric_group ?: pm->metric_name); 459 459 if (!mg) 460 460 return -ENOMEM; 461 461 omg = mg; ··· 466 466 if (strlen(g)) 467 467 me = mep_lookup(groups, g, pm->metric_name); 468 468 else 469 - me = mep_lookup(groups, "No_group", pm->metric_name); 469 + me = mep_lookup(groups, pm->metric_name, pm->metric_name); 470 470 471 471 if (me) { 472 472 me->metric_desc = pm->desc;