Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

ext4: improve error msg for ext4_mb_seq_groups_show

While cat mb_groups for a mounted ext4 image which has some corrupted
group, the string return to userspace was just "I/O error" which confuse
me a lot. Improve it with ext4_decode_error.

Signed-off-by: yangerkun <yangerkun@huawei.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/20240118042557.380058-2-yangerkun@huawei.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>

authored by

yangerkun and committed by
Theodore Ts'o
4b55d343 25044880

+2 -1
+2 -1
fs/ext4/mballoc.c
··· 3016 3016 struct super_block *sb = pde_data(file_inode(seq->file)); 3017 3017 ext4_group_t group = (ext4_group_t) ((unsigned long) v); 3018 3018 int i, err; 3019 + char nbuf[16]; 3019 3020 struct ext4_buddy e4b; 3020 3021 struct ext4_group_info *grinfo; 3021 3022 unsigned char blocksize_bits = min_t(unsigned char, ··· 3043 3042 if (unlikely(EXT4_MB_GRP_NEED_INIT(grinfo))) { 3044 3043 err = ext4_mb_load_buddy(sb, group, &e4b); 3045 3044 if (err) { 3046 - seq_printf(seq, "#%-5u: I/O error\n", group); 3045 + seq_printf(seq, "#%-5u: %s\n", group, ext4_decode_error(NULL, err, nbuf)); 3047 3046 return 0; 3048 3047 } 3049 3048 ext4_mb_unload_buddy(&e4b);