Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

um: port_kern: fix -Wmissing-variable-declarations

I'm looking to enable -Wmissing-variable-declarations behind W=1. 0day
bot spotted the following instance:

arch/um/drivers/port_kern.c:147:14: warning: no previous extern
declaration for non-static variable 'port_work'
[-Wmissing-variable-declarations]
DECLARE_WORK(port_work, port_work_proc);
^
arch/um/drivers/port_kern.c:147:1: note: declare 'static' if the
variable is not intended to be used outside of this translation unit
DECLARE_WORK(port_work, port_work_proc);
^

This symbol is not referenced by more than one translation unit, so give
it static storage.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/llvm/202308081050.sZEw4cQ5-lkp@intel.com/
Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Richard Weinberger <richard@nod.at>

authored by

Nick Desaulniers and committed by
Richard Weinberger
4b038701 b10eee78

+1 -1
+1 -1
arch/um/drivers/port_kern.c
··· 144 144 local_irq_restore(flags); 145 145 } 146 146 147 - DECLARE_WORK(port_work, port_work_proc); 147 + static DECLARE_WORK(port_work, port_work_proc); 148 148 149 149 static irqreturn_t port_interrupt(int irq, void *data) 150 150 {