fpga: altera-hps2fpga: fix multiple init of l3_remap_lock

The global spinlock `l3_remap_lock` is reinitialized every time the
"probe" function `alt_fpga_bridge_probe()` is called. It should only be
initialized once. Use `DEFINE_SPINLOCK()` to initialize it statically.

Fixes: e5f8efa5c8bf ("ARM: socfpga: fpga bridge driver support")
Cc: <[e-mail]> # 4.10+
Signed-off-by: Ian Abbott <[e-mail]>
Reviewed-By: Moritz Fischer <[e-mail]>
Signed-off-by: Alan Tull <[e-mail]>
Signed-off-by: Greg Kroah-Hartman <[e-mail]>

drivers/fpga/altera-hps2fpga.c

···
 
 /* The L3 REMAP register is write only, so keep a cached value. */
 static unsigned int l3_remap_shadow;
-static spinlock_t l3_remap_lock;
+static DEFINE_SPINLOCK(l3_remap_lock);
 
 static int _alt_hps2fpga_enable_set(struct altera_hps2fpga_data *priv,
 				    bool enable)
···
 		dev_err(dev, "could not enable clock\n");
 		return -EBUSY;
 	}
-
-	spin_lock_init(&l3_remap_lock);
 
 	if (!of_property_read_u32(dev->of_node, "bridge-enable", &enable)) {
 		if (enable > 1) {