Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

NFSD: fix missing refcount in nfsd4_copy by nfsd4_do_async_copy

Need to initialize nfsd4_copy's refcount to 1 to avoid use-after-free
warning when nfs4_put_copy is called from nfsd4_cb_offload_release.

Fixes: ce0887ac96d3 ("NFSD add nfs4 inter ssc to nfsd4_copy")
Signed-off-by: Dai Ngo <dai.ngo@oracle.com>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>

authored by

Dai Ngo and committed by
J. Bruce Fields
49a36132 36e1e5ba

+1
+1
fs/nfsd/nfs4proc.c
··· 1486 1486 cb_copy = kzalloc(sizeof(struct nfsd4_copy), GFP_KERNEL); 1487 1487 if (!cb_copy) 1488 1488 goto out; 1489 + refcount_set(&cb_copy->refcount, 1); 1489 1490 memcpy(&cb_copy->cp_res, &copy->cp_res, sizeof(copy->cp_res)); 1490 1491 cb_copy->cp_clp = copy->cp_clp; 1491 1492 cb_copy->nfserr = copy->nfserr;