Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

ext4: use 'sbi' instead of 'EXT4_SB(sb)'

We could use 'sbi' instead of 'EXT4_SB(sb)' to make code more elegant.

Signed-off-by: Jun Piao <piaojun@huawei.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Reviewed-by: Jan Kara <jack@suse.cz>

authored by

Jun Piao and committed by
Theodore Ts'o
49598e04 06f29cc8

+18 -18
+2 -2
fs/ext4/balloc.c
··· 355 355 blk = ext4_inode_table(sb, desc); 356 356 offset = blk - group_first_block; 357 357 next_zero_bit = ext4_find_next_zero_bit(bh->b_data, 358 - EXT4_B2C(sbi, offset + EXT4_SB(sb)->s_itb_per_group), 358 + EXT4_B2C(sbi, offset + sbi->s_itb_per_group), 359 359 EXT4_B2C(sbi, offset)); 360 360 if (next_zero_bit < 361 - EXT4_B2C(sbi, offset + EXT4_SB(sb)->s_itb_per_group)) 361 + EXT4_B2C(sbi, offset + sbi->s_itb_per_group)) 362 362 /* bad bitmap for inode tables */ 363 363 return blk; 364 364 return 0;
+3 -3
fs/ext4/block_validity.c
··· 147 147 int ret; 148 148 149 149 if (!test_opt(sb, BLOCK_VALIDITY)) { 150 - if (EXT4_SB(sb)->system_blks.rb_node) 150 + if (sbi->system_blks.rb_node) 151 151 ext4_release_system_zone(sb); 152 152 return 0; 153 153 } 154 - if (EXT4_SB(sb)->system_blks.rb_node) 154 + if (sbi->system_blks.rb_node) 155 155 return 0; 156 156 157 157 for (i=0; i < ngroups; i++) { ··· 173 173 } 174 174 175 175 if (test_opt(sb, DEBUG)) 176 - debug_print_tree(EXT4_SB(sb)); 176 + debug_print_tree(sbi); 177 177 return 0; 178 178 } 179 179
+2 -2
fs/ext4/ialloc.c
··· 303 303 /* Do this BEFORE marking the inode not in use or returning an error */ 304 304 ext4_clear_inode(inode); 305 305 306 - es = EXT4_SB(sb)->s_es; 306 + es = sbi->s_es; 307 307 if (ino < EXT4_FIRST_INO(sb) || ino > le32_to_cpu(es->s_inodes_count)) { 308 308 ext4_error(sb, "reserved or nonexistent inode %lu", ino); 309 309 goto error_return; ··· 1157 1157 ext4_clear_state_flags(ei); /* Only relevant on 32-bit archs */ 1158 1158 ext4_set_inode_state(inode, EXT4_STATE_NEW); 1159 1159 1160 - ei->i_extra_isize = EXT4_SB(sb)->s_want_extra_isize; 1160 + ei->i_extra_isize = sbi->s_want_extra_isize; 1161 1161 ei->i_inline_off = 0; 1162 1162 if (ext4_has_feature_inline_data(sb)) 1163 1163 ext4_set_inode_state(inode, EXT4_STATE_MAY_INLINE_DATA);
+7 -7
fs/ext4/mballoc.c
··· 757 757 clear_bit(EXT4_GROUP_INFO_NEED_INIT_BIT, &(grp->bb_state)); 758 758 759 759 period = get_cycles() - period; 760 - spin_lock(&EXT4_SB(sb)->s_bal_lock); 761 - EXT4_SB(sb)->s_mb_buddies_generated++; 762 - EXT4_SB(sb)->s_mb_generation_time += period; 763 - spin_unlock(&EXT4_SB(sb)->s_bal_lock); 760 + spin_lock(&sbi->s_bal_lock); 761 + sbi->s_mb_buddies_generated++; 762 + sbi->s_mb_generation_time += period; 763 + spin_unlock(&sbi->s_bal_lock); 764 764 } 765 765 766 766 static void mb_regenerate_buddy(struct ext4_buddy *e4b) ··· 1447 1447 ext4_fsblk_t blocknr; 1448 1448 1449 1449 blocknr = ext4_group_first_block_no(sb, e4b->bd_group); 1450 - blocknr += EXT4_C2B(EXT4_SB(sb), block); 1450 + blocknr += EXT4_C2B(sbi, block); 1451 1451 ext4_grp_locked_error(sb, e4b->bd_group, 1452 1452 inode ? inode->i_ino : 0, 1453 1453 blocknr, ··· 4838 4838 if (in_range(ext4_block_bitmap(sb, gdp), block, count) || 4839 4839 in_range(ext4_inode_bitmap(sb, gdp), block, count) || 4840 4840 in_range(block, ext4_inode_table(sb, gdp), 4841 - EXT4_SB(sb)->s_itb_per_group) || 4841 + sbi->s_itb_per_group) || 4842 4842 in_range(block + count - 1, ext4_inode_table(sb, gdp), 4843 - EXT4_SB(sb)->s_itb_per_group)) { 4843 + sbi->s_itb_per_group)) { 4844 4844 4845 4845 ext4_error(sb, "Freeing blocks in system zone - " 4846 4846 "Block = %llu, count = %lu", block, count);
+1 -1
fs/ext4/resize.c
··· 1477 1477 goto exit_journal; 1478 1478 1479 1479 group = flex_gd->groups[0].group; 1480 - BUG_ON(group != EXT4_SB(sb)->s_groups_count); 1480 + BUG_ON(group != sbi->s_groups_count); 1481 1481 err = ext4_add_new_descs(handle, sb, group, 1482 1482 resize_inode, flex_gd->count); 1483 1483 if (err)
+3 -3
fs/ext4/super.c
··· 2677 2677 * compensate. 2678 2678 */ 2679 2679 if (sb->s_blocksize == 1024 && nr == 0 && 2680 - le32_to_cpu(EXT4_SB(sb)->s_es->s_first_data_block) == 0) 2680 + le32_to_cpu(sbi->s_es->s_first_data_block) == 0) 2681 2681 has_super++; 2682 2682 2683 2683 return (has_super + ext4_group_first_block_no(sb, bg)); ··· 3122 3122 { 3123 3123 struct ext4_sb_info *sbi = EXT4_SB(sb); 3124 3124 struct ext4_li_request *elr = NULL; 3125 - ext4_group_t ngroups = EXT4_SB(sb)->s_groups_count; 3125 + ext4_group_t ngroups = sbi->s_groups_count; 3126 3126 int ret = 0; 3127 3127 3128 3128 mutex_lock(&ext4_li_mtx); ··· 4837 4837 bool needs_barrier = false; 4838 4838 struct ext4_sb_info *sbi = EXT4_SB(sb); 4839 4839 4840 - if (unlikely(ext4_forced_shutdown(EXT4_SB(sb)))) 4840 + if (unlikely(ext4_forced_shutdown(sbi))) 4841 4841 return 0; 4842 4842 4843 4843 trace_ext4_sync_fs(sb, wait);