Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

can: gs_usb: gs_usb_receive_bulk_callback(): fix error message

Sinc commit 79a6d1bfe114 ("can: gs_usb: gs_usb_receive_bulk_callback():
unanchor URL on usb_submit_urb() error") a failing resubmit URB will print
an info message.

In the case of a short read where netdev has not yet been assigned,
initialize as NULL to avoid dereferencing an undefined value. Also report
the error value of the failed resubmit.

Fixes: 79a6d1bfe114 ("can: gs_usb: gs_usb_receive_bulk_callback(): unanchor URL on usb_submit_urb() error")
Reported-by: Jakub Kicinski <kuba@kernel.org>
Closes: https://lore.kernel.org/all/20260119181904.1209979-1-kuba@kernel.org/
Link: https://patch.msgid.link/20260120-gs_usb-fix-error-message-v1-1-6be04de572bc@pengutronix.de
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>

+2 -2
+2 -2
drivers/net/can/usb/gs_usb.c
··· 610 610 { 611 611 struct gs_usb *parent = urb->context; 612 612 struct gs_can *dev; 613 - struct net_device *netdev; 613 + struct net_device *netdev = NULL; 614 614 int rc; 615 615 struct net_device_stats *stats; 616 616 struct gs_host_frame *hf = urb->transfer_buffer; ··· 768 768 } 769 769 } else if (rc != -ESHUTDOWN && net_ratelimit()) { 770 770 netdev_info(netdev, "failed to re-submit IN URB: %pe\n", 771 - ERR_PTR(urb->status)); 771 + ERR_PTR(rc)); 772 772 } 773 773 } 774 774