tjh.dev
Linux kernel mirror (for testing)
git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel
os
linux
Input: lpc32xx_ts - convert to use BIT()
There is error from cppcheck tool.
"Shifting signed 32-bit value by 31 bits is undefined behaviour errors"
Signed-off-by: edison.jiang <jiangzhipeng@yulong.com>
Link: https://lore.kernel.org/r/20210316153150.1207-1-jzp0409@163.com
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
authored by
edison.jiang
and committed by
Dmitry Torokhov
4895bfe9
bfae2779
+5
-5
+5
-5
drivers/input/touchscreen/lpc32xx_ts.c
+5
-5
drivers/input/touchscreen/lpc32xx_ts.c
···
34
34
#define LPC32XX_TSC_AUX_MIN 0x38
35
35
#define LPC32XX_TSC_AUX_MAX 0x3C
36
36
37
-
#define LPC32XX_TSC_STAT_FIFO_OVRRN (1 << 8)
38
-
#define LPC32XX_TSC_STAT_FIFO_EMPTY (1 << 7)
37
+
#define LPC32XX_TSC_STAT_FIFO_OVRRN BIT(8)
38
+
#define LPC32XX_TSC_STAT_FIFO_EMPTY BIT(7)
39
39
40
40
#define LPC32XX_TSC_SEL_DEFVAL 0x0284
41
41
42
42
#define LPC32XX_TSC_ADCCON_IRQ_TO_FIFO_4 (0x1 << 11)
43
43
#define LPC32XX_TSC_ADCCON_X_SAMPLE_SIZE(s) ((10 - (s)) << 7)
44
44
#define LPC32XX_TSC_ADCCON_Y_SAMPLE_SIZE(s) ((10 - (s)) << 4)
45
-
#define LPC32XX_TSC_ADCCON_POWER_UP (1 << 2)
46
-
#define LPC32XX_TSC_ADCCON_AUTO_EN (1 << 0)
45
+
#define LPC32XX_TSC_ADCCON_POWER_UP BIT(2)
46
+
#define LPC32XX_TSC_ADCCON_AUTO_EN BIT(0)
47
47
48
-
#define LPC32XX_TSC_FIFO_TS_P_LEVEL (1 << 31)
48
+
#define LPC32XX_TSC_FIFO_TS_P_LEVEL BIT(31)
49
49
#define LPC32XX_TSC_FIFO_NORMALIZE_X_VAL(x) (((x) & 0x03FF0000) >> 16)
50
50
#define LPC32XX_TSC_FIFO_NORMALIZE_Y_VAL(y) ((y) & 0x000003FF)
51
51