Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

media: dvb-frontends: mb86a16: remove useless variables in signal_det()

Remove useless variables wait_t and wait_sym and code related.

Also, fix some coding style issues.

Addresses-Coverity-ID: 1226947

Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>

authored by

Gustavo A. R. Silva and committed by
Mauro Carvalho Chehab
488e27ad abc5b2cb

+7 -18
+7 -18
drivers/media/dvb-frontends/mb86a16.c
··· 415 415 int smrt, 416 416 unsigned char *SIG) 417 417 { 418 - 419 - int ret ; 420 - int smrtd ; 421 - int wait_sym ; 422 - 423 - u32 wait_t; 424 - unsigned char S[3] ; 425 - int i ; 418 + int ret; 419 + int smrtd; 420 + unsigned char S[3]; 421 + int i; 426 422 427 423 if (*SIG > 45) { 428 424 if (CNTM_set(state, 2, 1, 2) < 0) { 429 425 dprintk(verbose, MB86A16_ERROR, 1, "CNTM set Error"); 430 426 return -1; 431 427 } 432 - wait_sym = 40000; 433 428 } else { 434 429 if (CNTM_set(state, 3, 1, 2) < 0) { 435 430 dprintk(verbose, MB86A16_ERROR, 1, "CNTM set Error"); 436 431 return -1; 437 432 } 438 - wait_sym = 80000; 439 433 } 440 434 for (i = 0; i < 3; i++) { 441 435 if (i == 0) ··· 441 447 smrt_info_get(state, smrtd); 442 448 smrt_set(state, smrtd); 443 449 srst(state); 444 - wait_t = (wait_sym + 99 * smrtd / 100) / smrtd; 445 - if (wait_t == 0) 446 - wait_t = 1; 447 450 msleep_interruptible(10); 448 451 if (mb86a16_read(state, 0x37, &(S[i])) != 2) { 449 452 dprintk(verbose, MB86A16_ERROR, 1, "I2C transfer error"); 450 453 return -EREMOTEIO; 451 454 } 452 455 } 453 - if ((S[1] > S[0] * 112 / 100) && 454 - (S[1] > S[2] * 112 / 100)) { 455 - 456 + if ((S[1] > S[0] * 112 / 100) && (S[1] > S[2] * 112 / 100)) 456 457 ret = 1; 457 - } else { 458 + else 458 459 ret = 0; 459 - } 460 + 460 461 *SIG = S[1]; 461 462 462 463 if (CNTM_set(state, 0, 1, 2) < 0) {