Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

selftests/rseq: Fix: Fail thread registration when CONFIG_RSEQ=n

When linking the selftests against a libc which does not handle rseq
registration (before 2.35), rseq thread registration silently succeed
even with CONFIG_RSEQ=n because it erroneously thinks that libc is
handling rseq registration.

This is caused by setting the rseq ownership flag only after the
rseq_available() check. It should rather be set before the
rseq_available() check.

Set the rseq_size to 0 (error value) immediately after the
rseq_available() check fails rather than in the thread registration
functions.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lore.kernel.org/r/20221122203932.231377-2-mathieu.desnoyers@efficios.com

authored by

Mathieu Desnoyers and committed by
Peter Zijlstra
4842dadf 8ad075c2

+4 -2
+4 -2
tools/testing/selftests/rseq/rseq.c
··· 119 119 rseq_flags = *libc_rseq_flags_p; 120 120 return; 121 121 } 122 - if (!rseq_available()) 123 - return; 124 122 rseq_ownership = 1; 123 + if (!rseq_available()) { 124 + rseq_size = 0; 125 + return; 126 + } 125 127 rseq_offset = (void *)&__rseq_abi - rseq_thread_pointer(); 126 128 rseq_size = sizeof(struct rseq_abi); 127 129 rseq_flags = 0;