Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

MIPS: Fix cacheinfo overflow

The recently added MIPS cacheinfo support used a macro populate_cache()
to populate the cacheinfo structures depending on which caches are
present. However the macro contains multiple statements without
enclosing them in a do {} while (0) loop, so the L2 and L3 cache
conditionals in populate_cache_leaves() only conditionalised the first
statement in the macro.

This overflows the buffer allocated by detect_cache_attributes(),
resulting in boot failures under QEMU where neither the L2 or L2 caches
are present.

Enclose the macro statements in a do {} while (0) block to keep the
whole macro inside the conditionals.

Fixes: ef462f3b64e9 ("MIPS: Add cacheinfo support")
Reported-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: James Hogan <james.hogan@imgtec.com>
Tested-by: Guenter Roeck <linux@roeck-us.net>
Cc: Ralf Baechle <ralf@linux-mips.org>
Cc: Justin Chen <justin.chen@broadcom.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>
Cc: linux-mips@linux-mips.org
Cc: bcm-kernel-feedback-list@broadcom.com
Patchwork: https://patchwork.linux-mips.org/patch/15276/

+3 -1
+3 -1
arch/mips/kernel/cacheinfo.c
··· 17 17 18 18 /* Populates leaf and increments to next leaf */ 19 19 #define populate_cache(cache, leaf, c_level, c_type) \ 20 + do { \ 20 21 leaf->type = c_type; \ 21 22 leaf->level = c_level; \ 22 23 leaf->coherency_line_size = c->cache.linesz; \ ··· 25 24 leaf->ways_of_associativity = c->cache.ways; \ 26 25 leaf->size = c->cache.linesz * c->cache.sets * \ 27 26 c->cache.ways; \ 28 - leaf++; 27 + leaf++; \ 28 + } while (0) 29 29 30 30 static int __init_cache_level(unsigned int cpu) 31 31 {