Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

leds: lm3692x: Simplify with dev_err_probe()

Common pattern of handling deferred probe can be simplified with
dev_err_probe(). Less code and also it prints the error value.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: Pavel Machek <pavel@ucw.cz>

authored by

Krzysztof Kozlowski and committed by
Pavel Machek
47eaa8ba 23bdfe00

+4 -7
+4 -7
drivers/leds/leds-lm3692x.c
··· 394 394 led->regulator = devm_regulator_get_optional(&led->client->dev, "vled"); 395 395 if (IS_ERR(led->regulator)) { 396 396 ret = PTR_ERR(led->regulator); 397 - if (ret != -ENODEV) { 398 - if (ret != -EPROBE_DEFER) 399 - dev_err(&led->client->dev, 400 - "Failed to get vled regulator: %d\n", 401 - ret); 402 - return ret; 403 - } 397 + if (ret != -ENODEV) 398 + return dev_err_probe(&led->client->dev, ret, 399 + "Failed to get vled regulator\n"); 400 + 404 401 led->regulator = NULL; 405 402 } 406 403