Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

spi: tegra210-quad: Fix missin IRQ check in tegra_qspi_probe

This func misses checking for platform_get_irq()'s call and may passes the
negative error codes to request_threaded_irq(), which takes unsigned IRQ #,
causing it to fail with -EINVAL, overriding an original error code.
Stop calling request_threaded_irq() with invalid IRQ #s.

Fixes: 921fc1838fb0 ("spi: tegra210-quad: Add support for Tegra210 QSPI controller")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Link: https://lore.kernel.org/r/20220128165956.27821-1-linmq006@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>

authored by

Miaoqian Lin and committed by
Mark Brown
47c3e06e 3b8ab4da

+2
+2
drivers/spi/spi-tegra210-quad.c
··· 1240 1240 1241 1241 tqspi->phys = r->start; 1242 1242 qspi_irq = platform_get_irq(pdev, 0); 1243 + if (qspi_irq < 0) 1244 + return qspi_irq; 1243 1245 tqspi->irq = qspi_irq; 1244 1246 1245 1247 tqspi->clk = devm_clk_get(&pdev->dev, "qspi");