Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drm/bridge: nwl-dsi: Avoid potential multiplication overflow on 32-bit

As nwl_dsi.lanes is u32, and NSEC_PER_SEC is 1000000000L, the second
multiplication in

dsi->lanes * 8 * NSEC_PER_SEC

will overflow on a 32-bit platform. Fix this by making the constant
unsigned long long, forcing 64-bit arithmetic.

As iMX8 is arm64, this driver is currently used on 64-bit platforms
only, where long is 64-bit, so this cannot happen. But the issue will
start to happen when the driver is reused for a 32-bit SoC (e.g.
i.MX7ULP), or when code is copied for a new driver.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Fabio Estevam <festevam@gmail.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Link: https://patchwork.freedesktop.org/patch/msgid/ebb82941a86b4e35c4fcfb1ef5a5cfad7c1fceab.1626255956.git.geert+renesas@glider.be

authored by

Geert Uytterhoeven and committed by
Sam Ravnborg
47956bc8 6474e67e

+1 -1
+1 -1
drivers/gpu/drm/bridge/nwl-dsi.c
··· 190 190 u32 bpp = mipi_dsi_pixel_format_to_bpp(dsi->format); 191 191 192 192 return DIV64_U64_ROUND_UP(ps * dsi->mode.clock * bpp, 193 - dsi->lanes * 8 * NSEC_PER_SEC); 193 + dsi->lanes * 8ULL * NSEC_PER_SEC); 194 194 } 195 195 196 196 /*