Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

spi: spi-qcom-qspi: Fix remaining driver nits

Address remaining comments from original driver patch series

* Move RD_FIFO_CFG to be ordered corretly
* Expand spinlock comment

Signed-off-by: Ryan Case <ryandcase@chromium.org>
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Signed-off-by: Mark Brown <broonie@kernel.org>

authored by

Ryan Case and committed by
Mark Brown
478652f3 1fc12b05

+4 -4
+4 -4
drivers/spi/spi-qcom-qspi.c
··· 90 90 #define PIO_DATAOUT_1B 0x0020 91 91 #define PIO_DATAOUT_4B 0x0024 92 92 93 + #define RD_FIFO_CFG 0x0028 94 + #define CONTINUOUS_MODE BIT(0) 95 + 93 96 #define RD_FIFO_STATUS 0x002c 94 97 #define FIFO_EMPTY BIT(11) 95 98 #define WR_CNTS_MSK 0x7f0 ··· 101 98 #define RDY_32BYTE BIT(2) 102 99 #define RDY_16BYTE BIT(1) 103 100 #define FIFO_RDY BIT(0) 104 - 105 - #define RD_FIFO_CFG 0x0028 106 - #define CONTINUOUS_MODE BIT(0) 107 101 108 102 #define RD_FIFO_RESET 0x0030 109 103 #define RESET_FIFO BIT(0) ··· 139 139 struct device *dev; 140 140 struct clk_bulk_data clks[QSPI_NUM_CLKS]; 141 141 struct qspi_xfer xfer; 142 - /* Lock to protect data accessed by IRQs */ 142 + /* Lock to protect xfer and IRQ accessed registers */ 143 143 spinlock_t lock; 144 144 }; 145 145