Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

[media] si2168: Bounds check firmware

When reading the firmware and sending commands, the length must
be bounds checked to avoid overrunning the size of the command
buffer and smashing the stack if the firmware is not in the expected
format:

si2168 11-0064: found a 'Silicon Labs Si2168-B40'
si2168 11-0064: downloading firmware from file 'dvb-demod-si2168-b40-01.fw'
si2168 11-0064: firmware download failed -95
Kernel panic - not syncing: stack-protector: Kernel stack is corrupted in: ffffffffa085708f

Add the proper check.

Cc: stable@kernel.org
Reported-by: Stuart Auchterlonie <sauchter@redhat.com>
Reviewed-by: Antti Palosaari <crope@iki.fi>
Signed-off-by: Laura Abbott <labbott@fedoraproject.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>

authored by

Laura Abbott and committed by
Mauro Carvalho Chehab
47810b43 a828d72d

+4
+4
drivers/media/dvb-frontends/si2168.c
··· 502 502 /* firmware is in the new format */ 503 503 for (remaining = fw->size; remaining > 0; remaining -= 17) { 504 504 len = fw->data[fw->size - remaining]; 505 + if (len > SI2168_ARGLEN) { 506 + ret = -EINVAL; 507 + break; 508 + } 505 509 memcpy(cmd.args, &fw->data[(fw->size - remaining) + 1], len); 506 510 cmd.wlen = len; 507 511 cmd.rlen = 1;