tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
fork atom

module_param: make bool parameters really bool (arch)

module_param(bool) used to counter-intuitively take an int. In
fddd5201 (mid-2009) we allowed bool or int/unsigned int using a messy
trick.

It's time to remove the int/unsigned int option. For this version
it'll simply give a warning, but it'll break next kernel version.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

Rusty Russell 476bc001 2329abfa

+25 -25
+1 -1
arch/ia64/hp/common/aml_nfw.c
··· 31 31 MODULE_LICENSE("GPL"); 32 32 MODULE_DESCRIPTION("ACPI opregion handler for native firmware calls"); 33 33 34 - static int force_register; 34 + static bool force_register; 35 35 module_param_named(force, force_register, bool, 0); 36 36 MODULE_PARM_DESC(force, "Install opregion handler even without HPQ5001 device"); 37 37
+8 -8
arch/x86/kernel/apm_32.c
··· 383 383 static int ignore_normal_resume; 384 384 static int bounce_interval __read_mostly = DEFAULT_BOUNCE_INTERVAL; 385 385 386 - static int debug __read_mostly; 387 - static int smp __read_mostly; 386 + static bool debug __read_mostly; 387 + static bool smp __read_mostly; 388 388 static int apm_disabled = -1; 389 389 #ifdef CONFIG_SMP 390 - static int power_off; 390 + static bool power_off; 391 391 #else 392 - static int power_off = 1; 392 + static bool power_off = 1; 393 393 #endif 394 - static int realmode_power_off; 394 + static bool realmode_power_off; 395 395 #ifdef CONFIG_APM_ALLOW_INTS 396 - static int allow_ints = 1; 396 + static bool allow_ints = 1; 397 397 #else 398 - static int allow_ints; 398 + static bool allow_ints; 399 399 #endif 400 - static int broken_psr; 400 + static bool broken_psr; 401 401 402 402 static DECLARE_WAIT_QUEUE_HEAD(apm_waitqueue); 403 403 static DECLARE_WAIT_QUEUE_HEAD(apm_suspend_waitqueue);
+1 -1
arch/x86/kvm/mmu.c
··· 74 74 #endif 75 75 76 76 #ifdef MMU_DEBUG 77 - static int dbg = 0; 77 + static bool dbg = 0; 78 78 module_param(dbg, bool, 0644); 79 79 #endif 80 80
+9 -9
arch/x86/kvm/vmx.c
··· 51 51 MODULE_AUTHOR("Qumranet"); 52 52 MODULE_LICENSE("GPL"); 53 53 54 - static int __read_mostly enable_vpid = 1; 54 + static bool __read_mostly enable_vpid = 1; 55 55 module_param_named(vpid, enable_vpid, bool, 0444); 56 56 57 - static int __read_mostly flexpriority_enabled = 1; 57 + static bool __read_mostly flexpriority_enabled = 1; 58 58 module_param_named(flexpriority, flexpriority_enabled, bool, S_IRUGO); 59 59 60 - static int __read_mostly enable_ept = 1; 60 + static bool __read_mostly enable_ept = 1; 61 61 module_param_named(ept, enable_ept, bool, S_IRUGO); 62 62 63 - static int __read_mostly enable_unrestricted_guest = 1; 63 + static bool __read_mostly enable_unrestricted_guest = 1; 64 64 module_param_named(unrestricted_guest, 65 65 enable_unrestricted_guest, bool, S_IRUGO); 66 66 67 - static int __read_mostly emulate_invalid_guest_state = 0; 67 + static bool __read_mostly emulate_invalid_guest_state = 0; 68 68 module_param(emulate_invalid_guest_state, bool, S_IRUGO); 69 69 70 - static int __read_mostly vmm_exclusive = 1; 70 + static bool __read_mostly vmm_exclusive = 1; 71 71 module_param(vmm_exclusive, bool, S_IRUGO); 72 72 73 - static int __read_mostly yield_on_hlt = 1; 73 + static bool __read_mostly yield_on_hlt = 1; 74 74 module_param(yield_on_hlt, bool, S_IRUGO); 75 75 76 - static int __read_mostly fasteoi = 1; 76 + static bool __read_mostly fasteoi = 1; 77 77 module_param(fasteoi, bool, S_IRUGO); 78 78 79 79 /* ··· 81 81 * VMX and be a hypervisor for its own guests. If nested=0, guests may not 82 82 * use VMX instructions. 83 83 */ 84 - static int __read_mostly nested = 0; 84 + static bool __read_mostly nested = 0; 85 85 module_param(nested, bool, S_IRUGO); 86 86 87 87 #define KVM_GUEST_CR0_MASK_UNRESTRICTED_GUEST \
+2 -2
arch/x86/kvm/x86.c
··· 88 88 struct kvm_x86_ops *kvm_x86_ops; 89 89 EXPORT_SYMBOL_GPL(kvm_x86_ops); 90 90 91 - int ignore_msrs = 0; 92 - module_param_named(ignore_msrs, ignore_msrs, bool, S_IRUGO | S_IWUSR); 91 + static bool ignore_msrs = 0; 92 + module_param(ignore_msrs, bool, S_IRUGO | S_IWUSR); 93 93 94 94 bool kvm_has_tsc_control; 95 95 EXPORT_SYMBOL_GPL(kvm_has_tsc_control);
+2 -2
arch/x86/mm/mmio-mod.c
··· 75 75 76 76 /* module parameters */ 77 77 static unsigned long filter_offset; 78 - static int nommiotrace; 79 - static int trace_pc; 78 + static bool nommiotrace; 79 + static bool trace_pc; 80 80 81 81 module_param(filter_offset, ulong, 0); 82 82 module_param(nommiotrace, bool, 0);
+1 -1
arch/x86/platform/geode/alix.c
··· 27 27 28 28 #include <asm/geode.h> 29 29 30 - static int force = 0; 30 + static bool force = 0; 31 31 module_param(force, bool, 0444); 32 32 /* FIXME: Award bios is not automatically detected as Alix platform */ 33 33 MODULE_PARM_DESC(force, "Force detection as ALIX.2/ALIX.3 platform");
+1 -1
arch/x86/platform/iris/iris.c
··· 42 42 MODULE_DESCRIPTION("A power_off handler for Iris devices from EuroBraille"); 43 43 MODULE_SUPPORTED_DEVICE("Eurobraille/Iris"); 44 44 45 - static int force; 45 + static bool force; 46 46 47 47 module_param(force, bool, 0); 48 48 MODULE_PARM_DESC(force, "Set to one to force poweroff handler installation.");