Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

ARM: ptrace: Restore syscall skipping for tracers

Since commit 4e57a4ddf6b0 ("ARM: 9107/1: syscall: always store
thread_info->abi_syscall"), the seccomp selftests "syscall_errno"
and "syscall_faked" have been broken. Both seccomp and PTRACE depend
on using the special value of "-1" for skipping syscalls. This value
wasn't working because it was getting masked by __NR_SYSCALL_MASK in
both PTRACE_SET_SYSCALL and get_syscall_nr().

Explicitly test for -1 in PTRACE_SET_SYSCALL and get_syscall_nr(),
leaving it exposed when present, allowing tracers to skip syscalls
again.

Cc: Russell King <linux@armlinux.org.uk>
Cc: Arnd Bergmann <arnd@kernel.org>
Cc: Lecopzer Chen <lecopzer.chen@mediatek.com>
Cc: Oleg Nesterov <oleg@redhat.com>
Cc: linux-arm-kernel@lists.infradead.org
Fixes: 4e57a4ddf6b0 ("ARM: 9107/1: syscall: always store thread_info->abi_syscall")
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
Link: https://lore.kernel.org/r/20230810195422.2304827-2-keescook@chromium.org
Signed-off-by: Kees Cook <keescook@chromium.org>

+6 -2
+3
arch/arm/include/asm/syscall.h
··· 25 25 if (IS_ENABLED(CONFIG_AEABI) && !IS_ENABLED(CONFIG_OABI_COMPAT)) 26 26 return task_thread_info(task)->abi_syscall; 27 27 28 + if (task_thread_info(task)->abi_syscall == -1) 29 + return -1; 30 + 28 31 return task_thread_info(task)->abi_syscall & __NR_SYSCALL_MASK; 29 32 } 30 33
+3 -2
arch/arm/kernel/ptrace.c
··· 783 783 break; 784 784 785 785 case PTRACE_SET_SYSCALL: 786 - task_thread_info(child)->abi_syscall = data & 787 - __NR_SYSCALL_MASK; 786 + if (data != -1) 787 + data &= __NR_SYSCALL_MASK; 788 + task_thread_info(child)->abi_syscall = data; 788 789 ret = 0; 789 790 break; 790 791